Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sage-env-config as part of sage_conf #29850

Closed
mkoeppe opened this issue Jun 12, 2020 · 64 comments
Closed

Install sage-env-config as part of sage_conf #29850

mkoeppe opened this issue Jun 12, 2020 · 64 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 12, 2020

As a follow-up to #21559 and #30128, we reassign sage-env-config from the package sagelib to the package sage_conf.

(After #22731, sage-env-config is no longer required by the sage script.)

(This is preparation for allowing installation of sagelib for example in a conda environment without having to run ./configure first - see #28745, #30845.)


Part of Meta-ticket #21707: Split sage-env into 5 to clean up sage configuration

Depends on #31002

CC: @jhpalmieri @kiwifb @orlitzky @dimpase @isuruf @tobiasdiez

Component: build

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: 4b52dcf

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29850

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 12, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2020

Dependencies: #29825

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2020

Changed dependencies from #29825 to #29825, #21559

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 13, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 13, 2020

Changed dependencies from #29825, #21559 to #29825, #21559, #29803

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 13, 2020

comment:4

Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.


Last 10 new commits:

70378edbuild/pkgs/pip/dependencies: Add wheel, simplify $(PYTHON) python3 to $(PYTHON)
10a2bacbuild/pkgs/setuptools, build/pkgs/pip: Remove python2 support from dependencies, install scripts
6755adbbuild/pkgs/pkgconfig/spkg-install.in: Remove pyproject.toml so that pip installs using setup.py
29327d3build/pkgs/entrypoints: Do not provide setup.py, not needed for entrypoints 0.3
bcc79a5build/pkgs/entrypoints/spkg-install.in: Remove pyproject.toml so that setup.py is used
361b98bbuild/pkgs/terminado/spkg-install.in: Remove pyproject.toml so that setup.py is used
5040d7ebuild/pkgs/testpath/spkg-install.in: Remove pyproject.toml so that setup.py is used
371ede6build/pkgs/zope_interface: Change to a dummy script package
10a2bacMerge branch 't/29803/upgrade_setuptools__pip__2020_06_' into t/29850/install_sage_env_config_with_sage_conf
dacea8bWIP: Install sage-env-config with sage_conf

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 13, 2020

Commit: dacea8b

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 13, 2020

comment:5

Perhaps it's easier to get rid of sage-env-config altogether (#29852).

@mkoeppe mkoeppe changed the title Install sage-env-config with sage_conf Install sage-env-config as part of sage_conf Jun 13, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 13, 2020

comment:7

Replying to @mkoeppe:

Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.

Using flit instead of setuptools (#29854) does not help for this ticket because flit does not know how to install prepared shell scripts -- it can only install Python scripts

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 14, 2020

Changed commit from dacea8b to 5f7b1cc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 14, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

1ee054cFixup
5f7b1ccMerge branch 't/21559/change-src-bin-installation' into t/29850/install_sage_env_config_with_sage_conf

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 14, 2020

comment:9

Replying to @mkoeppe:

Branch on this ticket does NOT work because pip/setuptools do not handle the symlink well.

It would probably suffice to just replace the use of pip by setup.py install.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 24, 2020

Work Issues: use setup.py install, add spkg-src

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

ae07682Merge tag '9.2.beta1' into t/29850/install_sage_env_config_with_sage_conf
a4e4124build/pkgs/sage_conf/spkg-install: Install with setup.py instead of pip
308ca69build/pkgs/sage_conf/spkg-src: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2020

Changed commit from 5f7b1cc to 308ca69

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 24, 2020

Changed work issues from use setup.py install, add spkg-src to make sage-env-config optional for sage-env

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 24, 2020

Changed work issues from make sage-env-config optional for sage-env to none

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 24, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 28, 2020

Work Issues: Move sage_conf.py to SAGE_ROOT/src/, symlink to there

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 28, 2020

comment:17

(comment was meant for a different ticket)

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 2, 2020

Changed work issues from Move sage_conf.py to SAGE_ROOT/src/, symlink to there to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

3a0193csrc/bin/sage: Remove handling of 'sage -axiom'
6b04075Merge branch 't/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution' into t/21559/change-src-bin-installation
9c7116bsrc/bin/sage-list-optional, sage-list-experimental, sage-list-standard: Remove deprecated scripts
831cc09Merge branch 't/29920/remove_deprecated_scripts_sage_list_optional__sage_list_experimental__sage_list_standard' into t/21559/change-src-bin-installation
e3eca85Merge branch 'public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup' of git://trac.sagemath.org/sage into t/21559/change-src-bin-installation
7d29141src/setup.py: Do not install removed script sage-rsyncdist
c5f7f2fMerge tag '9.2.beta3' into t/21559/change-src-bin-installation
6bc0cd4Install sage-env-config with sage_conf
5e6ca95build/pkgs/sage_conf/spkg-install: Install with setup.py instead of pip
0330180build/pkgs/sage_conf/spkg-src: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 14, 2020

Changed work issues from Rebase on top of #22731 to none

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Install sage-env-config as part of sage_conf; make sage-env-config optional Install sage-env-config as part of sage_conf Nov 14, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2020

Changed dependencies from #22731 to #31002

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2020

Work Issues: use new function from #31002

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 6, 2020

Changed work issues from use new function from #31002 to use new function from #31002 - or use #30013 and move sage-env-config into the sage_conf source directory

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2020

Changed commit from 5dc4266 to 4b52dcf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

a8e0364Specify bdist temp folder for WSL compatibility
a3077c7Use mktemp
c5a14a3build/bin/sage-dist-helpers (sdh_setup_bdist_wheel): New
fb10429build/pkgs/*/spkg-install.in: Use new function sdh_setup_bdist_wheel
5f11e24Merge branch 'public/build/bdist_wsl' of git://trac.sagemath.org/sage into t/29850/install_sage_env_config_with_sage_conf
0773001Merge tag '9.3.beta3' into t/29850/install_sage_env_config_with_sage_conf
4b52dcfbuild/pkgs/sage_conf/spkg-install: Use sdh_setup_bdist_wheel

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 8, 2020

Changed work issues from use new function from #31002 - or use #30013 and move sage-env-config into the sage_conf source directory to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 11, 2020

comment:45

Still needs review...

@dimpase
Copy link
Member

dimpase commented Dec 11, 2020

comment:46

OK.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 11, 2020

comment:47

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 13, 2020

Changed branch from u/mkoeppe/install_sage_env_config_with_sage_conf to 4b52dcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants