Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test suites for curl, git, cmake #30093

Closed
jhpalmieri opened this issue Jul 8, 2020 · 11 comments
Closed

Disable test suites for curl, git, cmake #30093

jhpalmieri opened this issue Jul 8, 2020 · 11 comments

Comments

@jhpalmieri
Copy link
Member

We don't need to run extensive test suites for curl, git, or cmake: (a) if they have problems, they don't affect the mathematical correctness of Sage's output, they just affect the build process; (b) if they have minor problems, they won't even affect the build process, so we shouldn't care; (c) these particular test suites can take a long time, at least for git, and they often fail; (d) most users already have these on their systems outside of Sage (or at least git and curl).

Component: packages: standard

Author: John Palmieri

Branch/Commit: 6abb078

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30093

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 8, 2020

comment:1

cmake is also in the same category

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/no-test-suite-git-curl

@jhpalmieri
Copy link
Member Author

New commits:

f3f9b21trac 30093: skip test suite for curl and git.

@jhpalmieri
Copy link
Member Author

Commit: f3f9b21

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2020

Changed commit from f3f9b21 to 6abb078

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6abb078trac 30093: skip test suite for curl, git, cmake

@jhpalmieri

This comment has been minimized.

@jhpalmieri jhpalmieri changed the title Disable test suites for curl and git Disable test suites for curl, git, cmake Jul 8, 2020
@jhpalmieri

This comment has been minimized.

@jhpalmieri

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 8, 2020

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Jul 15, 2020

Changed branch from u/jhpalmieri/no-test-suite-git-curl to 6abb078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants