-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 support #30551
Comments
comment:1
I don't think there is anything that says that we "should" drop Python 3.6 support. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
#30053 says that we must drop Python 3.6 - unless you want to have a go at it. it seems that some of our code related to docbuilding is too new for 3.6, and perhaps our Sphinx is too new too. Besides, the EOL for 3.6 is late 2021, which is soon. |
This comment has been minimized.
This comment has been minimized.
comment:6
What do you think about adopting the Python version strategy of numpy, according to which "a project with a major or minor version release in November 2020 should support Python 3.7 and newer"? |
comment:7
Replying to @tobiasdiez:
That's #30384 |
comment:8
According to NEP 29, "a project with a major or minor version release in November 2020 should support Python 3.7 and newer." and thus this ticket can be closed in my opinion. (Documentation for following NEP 29 is added in #30384.) |
comment:9
??! This ticket is for dropping support for Python 3.6 -- this involves changing what system python versions we accept ( NEP 29 would already allow us to drop support now -- but I don't think we want to do it now (because of Sage's traditional role of providing a distribution that people can install onto ancient machines) -- hence the milestone is set to "pending". |
Commit: |
comment:11
Sorry, it wasn't clear to me from the ticket description that this is more than a placeholder to mark dependencies on Python 3.6. NEP 29 is actually quite explicit about that one should drop support after the 42 months, e.g "On Jun 23, 2020 drop support for Python 3.6 (initially released on Dec 23, 2016)". Of course, it could be sage's policy to support also older python versions, but that's then no longer NEP 29 (in it's strict form). However, one should also keep in mind that supporting old Python versions results in technical debt that might be bigger than the gains from supporting old systems. Also correct me if I'm wrong, but since sage is also installing its own python version, sage can still be used on older systems, right? It is just that the system python is not used. Anyway, I've tried to locate all workarounds that are in place for Python 3.6 support, and removed them (I've probably missed a few, but maybe its good anyway to pay of the technical debt in follow up tickets). Moreover, I've upgraded the requirements to 3.7 (again, I might have missed something). New commits:
|
Branch: public/python3/drop36 |
comment:12
Other projects dropping support for Python 3.6:
|
comment:13
In this change:
Both the original text and the new one are not correct. This part refers to the |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Replying to @mkoeppe:
I've changed the versions now. |
comment:44
Replying to @dimpase:
It is a change to |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:47
@vbraun - if it's too late for this change, I can also put this reverting commit on a new ticket. |
comment:48
ok. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits: |
comment:51
I've put the missing commit on #31860. |
Changed branch from public/python3/drop36 to |
This can be a dependency for other tickets.
For instance tickets updating dependencies to
versions that dropped support for Python 3.6.
Related:
Depends on #30913
CC: @fchapoton @mkoeppe @orlitzky @dimpase @vbraun
Component: python3
Author: Tobias Diez, Matthias Koeppe
Branch/Commit:
b06731c
Reviewer: Matthias Koeppe, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/30551
The text was updated successfully, but these errors were encountered: