Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sage.libs.ppl #30595

Closed
mkoeppe opened this issue Sep 18, 2020 · 15 comments
Closed

Remove deprecated sage.libs.ppl #30595

mkoeppe opened this issue Sep 18, 2020 · 15 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 18, 2020

In #23024 (merged in Sage 8.7), sage.libs.ppl was deprecated and all uses converted to using the standalone library pplpy.

We remove the deprecated library.

CC: @videlec @jplab @kliem @tscrim @fchapoton

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 8c51242

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/30595

@mkoeppe mkoeppe added this to the sage-9.2 milestone Sep 18, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

Changed branch from u/mkoeppe/remove_deprecated_sage_libs_ppl to none

@jhpalmieri
Copy link
Member

comment:3

The branch was deleted?

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

Commit: 27de60f

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

comment:5

Now it's back


New commits:

27de60fsage.libs.ppl: Remove

@kliem
Copy link
Contributor

kliem commented Sep 18, 2020

comment:6

Documentation doesn't build:

[dochtml] Error building the documentation.
[dochtml] Traceback (most recent call last):
[dochtml]   File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
[dochtml]     "__main__", mod_spec)
[dochtml]   File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
[dochtml]     exec(code, run_globals)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__main__.py", line 2, in <module>
[dochtml]     main()
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 1730, in main
[dochtml]     builder()
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 344, in _wrapper
[dochtml]     getattr(get_builder(document), 'inventory')(*args, **kwds)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 570, in _wrapper
[dochtml]     self._build_everything_except_bibliography(lang, format, *args, **kwds)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 556, in _build_everything_except_bibliography
[dochtml]     build_many(build_ref_doc, non_references)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 296, in build_many
[dochtml]     _build_many(target, args, processes=NUM_THREADS)
[dochtml]   File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage_setup/docbuild/utils.py", line 289, in build_many
[dochtml]     raise worker_exc.original_exception
[dochtml] OSError: WARNING: autodoc: failed to import module 'ppl' from module 'sage.libs'; the following exception was raised:

@seblabbe
Copy link
Contributor

Changed commit from 27de60f to 8c51242

@seblabbe
Copy link
Contributor

comment:7

Added a small commit which removes sage/libs/ppl from the doc.


New commits:

8c5124230595: remove sage/libs/ppl from doc

@seblabbe
Copy link
Contributor

Changed branch from u/mkoeppe/remove_deprecated_sage_libs_ppl to public/30595

@fchapoton
Copy link
Contributor

comment:8

looks good.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2020

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 27, 2020

Changed branch from public/30595 to 8c51242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants