Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openblas to build with Xcode 12 #30610

Closed
jhpalmieri opened this issue Sep 18, 2020 · 11 comments
Closed

Fix openblas to build with Xcode 12 #30610

jhpalmieri opened this issue Sep 18, 2020 · 11 comments
Labels
c: packages: standard p: critical / 2 t: bug
Milestone
sage-9.2

Comments

@jhpalmieri
Copy link
Member

OpenBLAS fails to build with Xcode 12 (as can be seen for example in https://github.com/mkoeppe/sage/runs/1141519170). The fix at OpenMathLib/OpenBLAS#2805, more precisely,
OpenMathLib/OpenBLAS#2808 - and can be backported to 0.3.9 or 0.3.10.

This is marked critical, not a blocker, since there is a workable homebrew package that can be used instead.

Upstream: None of the above - read trac for reasoning.

CC: @mkoeppe @jhpalmieri

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: b4315c2

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30610
@jhpalmieri jhpalmieri added this to the sage-9.2 milestone Sep 18, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@dimpase

This comment has been minimized.

Sign in to view
@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

comment:3

see
OpenMathLib/OpenBLAS#2805 (comment)

applying a patch to OpenBLAS's lapack.h allows one to build version 0.3.9

@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

Commit: b4315c2

@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

Branch: u/dimpase/packages/openblas/xcode12patch

@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

Upstream: None of the above - read trac for reasoning.

@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

New commits:

b4315c2backport of the relevant part of upstream PR 2808

@dimpase
Copy link
Member

dimpase commented Sep 22, 2020

Author: Dima Pasechnik

@jhpalmieri
Copy link
Member Author

comment:6

This works for me.

@jhpalmieri
Copy link
Member Author

Reviewer: John Palmieri

@vbraun
Copy link
Member

vbraun commented Sep 27, 2020

Changed branch from u/dimpase/packages/openblas/xcode12patch to b4315c2

@vbraun vbraun closed this as completed in 501019f Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @dimpase @jhpalmieri @mkoeppe