Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora-33-standard/homebrew-macos flint/arb breakage #30757

Closed
mkoeppe opened this issue Oct 11, 2020 · 12 comments
Closed

fedora-33-standard/homebrew-macos flint/arb breakage #30757

mkoeppe opened this issue Oct 11, 2020 · 12 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Oct 11, 2020

fedora-33-standard, https://github.com/sagemath/sage/runs/1235092189

  1. configure finds system flint but not system arb (headers are installed by the fedora package in /usr/include/arb/, but the arb spkg-configure expects them in /usr/include).

  2. Then compiling arb spkg results in:

  [arb-2.16.0.p0]   /sage/local/var/tmp/sage/build/arb-2.16.0.p0/src/fmpr.h:25:10: fatal error: flint/config.h: No such file or directory
  [arb-2.16.0.p0]      25 | #include "flint/config.h"
  [arb-2.16.0.p0]         |          ^~~~~~~~~~~~~~~~
  [arb-2.16.0.p0]   compilation terminated.

Indeed, /usr/include/flint/ is present, but config.h is missing.

For Sage 9.3, we can do the upgrade to arb 2.18.1 (#28623) and flint 2.6.3 (#29719). But we need a quick fix for Sage 9.2.

(fedora-33 is expected to be released 2020-10-20.)

Same error also on homebrew-macos with flint installed.

CC: @dimpase @jhpalmieri @orlitzky @fredrik-johansson @videlec @kiwifb @antonio-rojas

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 78edcc3

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30757

@mkoeppe mkoeppe added this to the sage-9.2 milestone Oct 11, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title fedora-33-standard flint/arb breakage fedora-33-standard/homebrew-macos flint/arb breakage Oct 14, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 14, 2020

comment:6

Should the install location of the arb headers in Fedora be considered a packaging bug?

@orlitzky
Copy link
Contributor

comment:7

Replying to @mkoeppe:

Should the install location of the arb headers in Fedora be considered a packaging bug?

Yes, any packager who relocates the public headers for their package has 100% broken its public API.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 16, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 16, 2020

Commit: 78edcc3

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 16, 2020

comment:9

To keep the scope limited this late in the 9.2 cycle, I have only cherry-picked a fix for arb from the #29719/#28623 branch


New commits:

78edcc3backport flint compat patch from arb's trunk

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 16, 2020

Author: Dima Pasechnik

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 16, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 16, 2020

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/310014066 to Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Oct 18, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants