-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to deprecation of seeding based on hashing in Python 3.9 #30765
Comments
This comment has been minimized.
This comment has been minimized.
comment:1
Possible workaround: silence the deprecation warning for now, See for instance:
|
Commit: |
Author: Frédéric Chapoton |
Branch: u/chapoton/30765 |
comment:3
I have made some general cleanup of pbori/ I have forced the seeds to be New commits:
|
comment:5
this does work with Python 3.9.0 - it does fix that warning. |
Reviewer: Dima Pasechnik |
comment:6
lgtm |
comment:7
Merge conflict |
comment:8
rebased over the latest beta New commits:
|
Changed branch from u/chapoton/30765 to public/30765 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
ok, I changed a few more details in the doc of fglm. I will allow myself to set this back to positive. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:12
ok, this works, too. |
Changed branch from public/30765 to |
Python 3.9 deprecates seeding based on hashing.
https://docs.python.org/3.9/library/random.html#random.seed
Deprecated since version 3.9: In the future, the seed must be
one of the following types: NoneType, int, float, str, bytes,
or bytearray.
This causes a doctest failure in Sage 9.2.rc0 using Python 3.9:
First discussed at #30184 (comments 25, 33, 40, 55).
CC: @kiwifb @mkoeppe @slel
Component: refactoring
Keywords: seed, hash, pbori, polybori, randompoly, deprecation
Author: Frédéric Chapoton
Branch/Commit:
de815db
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/30765
The text was updated successfully, but these errors were encountered: