bootstrap-clean must remove src/bin/sage-env-config

[dimpase]

Otherwise on partially configured trees this might be a problem.
Here is a reproduction of a real bug I hit with a student today

dima@hilbert /mnt/opt/Sage/sage-clang $ echo Foo > src/bin/sage-env-config
dima@hilbert /mnt/opt/Sage/sage-clang $ make bootstrap-clean 
...
dima@hilbert /mnt/opt/Sage/sage-clang $ ./bootstrap 
rm -rf config configure build/make/Makefile-auto.in
rm -f src/doc/en/installation/*.txt
rm -rf src/doc/en/reference/spkg/*.rst
rm -f src/doc/en/reference/repl/*.txt
src/bin/sage-env-config: line 1: Foo: command not found
must source sage-env-config before sage-env
src/doc/bootstrap:56: installing src/doc/en/installation/arch.txt and src/doc/en/installation/arch-optional.txt
src/doc/bootstrap:56: installing src/doc/en/installation/debian.txt and src/doc/en/installation/debian-optional.txt
src/doc/bootstrap:56: installing src/doc/en/installation/fedora.txt and src/doc/en/installation/fedora-optional.txt
src/doc/bootstrap:56: installing src/doc/en/installation/cygwin.txt and src/doc/en/installation/cygwin-optional.txt
src/doc/bootstrap:56: installing src/doc/en/installation/homebrew.txt and src/doc/en/installation/homebrew-optional.txt
src/doc/bootstrap:65: installing src/doc/en/reference/spkg/*.rst
src/doc/bootstrap:97: installing src/doc/en/reference/repl/options.txt
/mnt/opt/Sage/sage-clang/src/bin/sage-env-config: line 1: Foo: command not found
must source sage-env-config before sage-env
Error setting environment variables by sourcing '/mnt/opt/Sage/sage-clang/src/bin/sage-env';
possibly contact sage-devel (see http://groups.google.com/group/sage-devel).

CC: @vbraun @orlitzky @mkoeppe

Component: build: configure

Branch: f612b22

Issue created by migration from https://trac.sagemath.org/ticket/30795

[dimpase]

Branch: u/dimpase/build/morecleanbootstrap

[dimpase]

Commit: f976c52

[mkoeppe]

comment:2

This does not seem to be the right branch

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f612b22

add the removal of sage-env-config

[sagetrac-git]

Changed commit from f976c52 to f612b22

[dimpase]

comment:4

should be ok now,
sorry for pushing this branch from a wrong window.

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

comment:6

Better development experience can't be a blocker

[vbraun]

Changed branch from u/dimpase/build/morecleanbootstrap to f612b22

[vbraun]

Changed commit from f612b22 to none

[vbraun]

comment:10

This breaks make clean && ./sage -sdist, which is what I'm using to create the source tarballs. One could require to first build Sage before making source tarballs, but I think thats a) complicated and b) error-prone as build artifacts going to sneak into source tarballs.

[dimpase]

comment:11

Replying to @vbraun:

This breaks make clean && ./sage -sdist, which is what I'm using to create the source tarballs. One could require to first build Sage before making source tarballs, but I think thats a) complicated and b) error-prone as build artifacts going to sneak into source tarballs.

but sage-env-config is a build artefact!

[dimpase]

comment:12

Replying to @vbraun:

This breaks make clean && ./sage -sdist, which is what I'm using to create the source tarballs. One could require to first build Sage before making source tarballs,

no, why? All sdist needs is to know SAGE_ROOT and SAGE_SRC - and this info definitely does not need Sage to be built.
I.e.

make clean && SAGE_ROOT=`pwd` SAGE_SRC=`pwd`/src ./sage -sdist

should work for you. If we really must, we can provide such defaults in build/bin/sage-sdist.

Please tell us how we should proceed here.

[vbraun]

comment:13

sage -sdist should work without setting environment variables. The path could also be hardcoded in the sage launcher script.

[mkoeppe]

comment:14

Volker, is having SAGE_SRC configurable by environment setting needed for your release management scripts? Otherwise I would suggest that we get rid of this configuration option.

[mkoeppe]

comment:15

The problem reported on the original ticket description is fixed in #30841.

But I think it's time to clean up the -clean targets - see #21566, #21775.

[dimpase]

comment:17

is this already merged? Can it be closed, or?

[mkoeppe]

Changed reviewer from Matthias Koeppe to none

[mkoeppe]

comment:18

I think it can be closed.

[mkoeppe]

Changed author from Dima Pasechnik to none