Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/python3: Remove libpng from dependencies, SAGE_SPKG_DEPCHECK #31009

Closed
mkoeppe opened this issue Dec 5, 2020 · 11 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 5, 2020

python3 does not seem to depend at all on libpng, so we should remove it from the declared dependencies (and the SAGE_SPKG_DEPCHECK).

This will allow us to accept system python 3.6 on centos-7 (see #29033), as can be seen by using

  tox -e docker-centos-7-standard -- config.status

and probably also on conda-forge-ubuntu-minimal (where currently the python3 build fails, even after the upgrade to 3.9.1 in #30589, https://github.com/mkoeppe/sage/runs/1566872755).

CC: @kiwifb @jhpalmieri @isuruf

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: b739470

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/31009

@mkoeppe mkoeppe added this to the sage-9.3 milestone Dec 5, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 5, 2020

Dependencies: #30559

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 5, 2020

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 5, 2020

New commits:

dd3fc1ebuild/pkgs/python3/spkg-configure.m4: Remove DEPCHECK on sqlite
efb9dccbuild/pkgs/sqlite/spkg-configure.m4: Set as not required if system python3 will be used
a39a9f1build/pkgs/cryptominisat/dependencies: Remove unused dep on sqlite
362f6c9build/pkgs/elliptic_curves/dependencies: Remove sqlite; the package only uses it through the sqlite python module
5ca8742Merge tag '9.3.beta0' into t/30559/refine_python3_s_sage_spkg_depcheck
08e3369sage.misc.sage_ostools: Link to sqlite only on Cygwin
4731840Merge tag '9.3.beta1' into t/30559/refine_python3_s_sage_spkg_depcheck
ed2e3d4Merge commit '4731840945a8598cbc97367e2b4ad60e6d9c6c7c' of git://trac.sagemath.org/sage into t/31009/build_pkgs_python3__remove_libpng_from_dependencies__sage_spkg_depcheck
b739470build/pkgs/python3: Remove libpng from dependencies, SAGE_SPKG_DEPCHECK

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 5, 2020

Commit: b739470

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 5, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed dependencies from #30559 to none

@mkoeppe

This comment has been minimized.

@isuruf
Copy link
Member

isuruf commented Dec 27, 2020

Reviewer: Isuru Fernando

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 28, 2020

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants