Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: cygwin: Move rpy2 to TARGETS_OPTIONAL #31438

Closed
mkoeppe opened this issue Feb 27, 2021 · 16 comments
Closed

GH Actions: cygwin: Move rpy2 to TARGETS_OPTIONAL #31438

mkoeppe opened this issue Feb 27, 2021 · 16 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 27, 2021

As a follow up to #31409, which made r and rpy2 optional.
We move the rpy2 from TARGETS to TARGETS_OPTIONAL so that build errors do not block the later test stages.

Depends on #31409
Depends on #31064

CC: @kliem @embray @jhpalmieri

Component: porting: Cygwin

Branch/Commit: u/mkoeppe/gh_actions__cygwin__move_rpy2_to_targets_optional @ 52792d4

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/31438

@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 27, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 27, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 27, 2021

Commit: 732ec63

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 27, 2021

New commits:

b2d4ab8build/pkgs/{r,rpy2}: Downgrade to optional
8732076src/sage/repl/ipython_tests.py: Mark R interface tests # optional - rpy2
dbdf084src/sage/structure/sage_object.pyx: Mark R interface test # optional - rpy2
737b21csrc/sage/stats/r.py: Mark all 2 doctests in this file as # optional - rpy2
4403924src/sage/interfaces/r.py: Mark all tests # optional - rpy2
405ebb9More # optional - rpy2
bc2f54dMerge branch 't/31409/cygwin_standard__r_build_fails_____downgrade_r__rpy2_to_optional' into t/31438/gh_actions__cygwin__move_rpy2_to_targets_optional
732ec63.github/workflows/ci-cygwin*.yml: Move rpy2 to TARGETS_OPTIONAL

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 27, 2021

Changed dependencies from #31409 to #31409, #31064

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 27, 2021

Changed commit from 732ec63 to f99cbeb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 27, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

cf31b79Fixup after cherry-pick
073124cMerge branch 't/31084/makefile__add__ptest__targets_that_do_not_depend_on_the_docbuild' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
8769bd6.github/workflows/ci-cygwin-*.yml: Separate docbuild and ptest
3826222Fix up stage iv
598b0c2local-cygwin-choco: Do not pass through PATH, use full pathname of choco instead
d65299cMerge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
a5e4051Merge branch 't/30944/tox__improve_local_sudo_ubuntu_standard' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
42f4458Merge tag '9.3.beta7' into t/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq
2f62998Merge branch 't/31064/ci_cygwin__yml__adjust_to_new_script_packages__bootstrap___prereq' into t/31438/gh_actions__cygwin__move_rpy2_to_targets_optional
f99cbeb.github/workflows/ci-cygwin*.yml: Move rpy2 to TARGETS_OPTIONAL

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 27, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 27, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2021

Changed commit from f99cbeb to 52792d4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b7c1576Merge tag '9.3.beta8' into t/31409/cygwin_standard__r_build_fails_____downgrade_r__rpy2_to_optional
ce3b35fMore # optional - r
52792d4Merge branch 't/31409/cygwin_standard__r_build_fails_____downgrade_r__rpy2_to_optional' into t/31438/gh_actions__cygwin__move_rpy2_to_targets_optional

@dimpase
Copy link
Member

dimpase commented Mar 8, 2021

comment:9

Cygwin build errors out while building Pynac

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 8, 2021

comment:10

Replying to @dimpase:

Cygwin build errors out while building Pynac

Not this ticket's fault. The test runs are for the Singular upgrade in #25993

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 12, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/606112478 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 12, 2021

Changed author from Matthias Koeppe to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 12, 2021

comment:11

Not needed any more now that the r/rpy2 crisis has been averted

@mkoeppe mkoeppe removed this from the sage-9.3 milestone Mar 12, 2021
@orlitzky
Copy link
Contributor

orlitzky commented Feb 7, 2022

Reviewer: Michael Orlitzky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants