cython: Upgrade to 0.29.24, fix Cython 3.0 future-warnings

[mkoeppe]

https://cython.readthedocs.io/en/latest/src/changes.html#id15

CC: @tscrim @antonio-rojas @kiwifb

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 153a5df

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/31445

[mkoeppe]

comment:2

cython 0.29.22 issues future-warnings:

  warning: sage/groups/perm_gps/partn_ref2/refinement_generic.pxd:38:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
  warning: sage/groups/perm_gps/partn_ref2/refinement_generic.pxd:38:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables

[mkoeppe]

comment:3

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

[mkoeppe]

Branch: u/mkoeppe/cython__upgrade_to_0_29_23__fix_cython_3_0_future_warnings

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

6ca849f

build/pkgs/cython: Update to 0.29.23

[mkoeppe]

Commit: 6ca849f

[mkoeppe]

comment:7

Does someone already have patches to fix the deprecation warnings that Cython 0.29.23 issues?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4637471

build/pkgs/cython: Update to 0.29.24

[sagetrac-git]

Changed commit from 6ca849f to 4637471

[mkoeppe]

comment:10

List of warnings:

    warning: sage/groups/perm_gps/partn_ref2/refinement_generic.pxd:38:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/matrix/matrix_modn_dense_template.pxi:189:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/matrix/matrix_modn_dense_template.pxi:257:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/matrix/matrix_modn_dense_template.pxi:258:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/matrix/matrix_modn_dense_template.pxi:278:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/matrix/matrix_modn_dense_template.pxi:300:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/numerical/backends/generic_sdp_backend.pxd:34:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/numerical/linear_tensor_element.pxd:4:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/rings/laurent_series_ring_element.pxd:4:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/rings/padics/CR_template.pxi:1218:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/rings/polynomial/laurent_polynomial.pxd:15:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/rings/power_series_mpoly.pxd:5:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables
    warning: sage/rings/puiseux_series_ring_element.pxd:5:11: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables

[sagetrac-git]

Changed commit from 4637471 to 153a5df

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

153a5df

Change all cpdef variables to cdef variables

[kiwifb]

comment:13

My first reaction was that it wasn't many in your list. I have grepped sage source code for "cpdef" and it comes out at 3624 lines across 444 files. Why would the one you change be the only ones producing warnings?

[mkoeppe]

comment:14

Functions defined with cpdef do not need changing, only variables.

[kiwifb]

comment:15

OK, that weeds a lot of things. I still have 51 warnings currently which is much more than what you patch.

I will test the patch to see if I still see some afterwards.

[mkoeppe]

comment:16

My list of warnings above has been run through sort -u; many appear multiple times

[kiwifb]

Reviewer: François Bissey

[kiwifb]

comment:17

Replying to @mkoeppe:

My list of warnings above has been run through sort -u; many appear multiple times

Indeed, that reduces the number to 13 which matches your list. It looks very good now.

[mkoeppe]

comment:18

Thank you!

[vbraun]

Changed branch from u/mkoeppe/cython__upgrade_to_0_29_23__fix_cython_3_0_future_warnings to 153a5df