Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ipython to 7.16.x and jedi to 0.17.x to restore Python 3.6 support (ubuntu-bionic-standard) #31476

Closed
mkoeppe opened this issue Mar 10, 2021 · 24 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 10, 2021

(from #31373)

Depends on #31373

CC: @kliem

Component: packages: standard

Author: Matthias Koeppe, Jonathan Kliem

Branch/Commit: 50084a8

Reviewer: Jonathan Kliem, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31476

@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 10, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

Commit: 140af6a

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

New commits:

3b7d7e5upgrade jedi and ipython
b48a79bMerge #31373
140af6abuild/pkgs/ipython: Downgrade to 7.16.1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

Dependencies: #31373

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:4

This ticket breaks it completely.

I can't tab-complete anymore and if I try it get and awful error with a hard crash of sage.

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:5

Attachment: Sage_crash_report.txt

Maybe this reason: ipython/ipython#12740

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:6

Should downgrade jedi to 0.17.0 again.

I will open a seperate ticket to address the issues of #31373.

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

Changed commit from 140af6a to 468a828

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

New commits:

468a828downgrade jedi, as 0.18.0 is supported only by ipython 7.18.1 and higher

@kliem kliem changed the title Downgrade ipython to 7.16.x to restore Python 3.6 support (ubuntu-bionic-standard) Downgrade ipython to 7.16.x and jedi to 0.17.0 to restore Python 3.6 support (ubuntu-bionic-standard) Mar 10, 2021
@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

Changed author from Matthias Koeppe to Matthias Koeppe, Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

comment:11

Shouldn't we use jedi 0.17.2 then?

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:12

Yes. I just didn't check and assumed that 0.17.0 is below 0.18.0. 0.17.2 mentions python 3.9 support, so that's a plus.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

Changed commit from 468a828 to 50084a8

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

New commits:

50084a8build/pkgs/jedi: Update to 0.17.2

@mkoeppe mkoeppe changed the title Downgrade ipython to 7.16.x and jedi to 0.17.0 to restore Python 3.6 support (ubuntu-bionic-standard) Downgrade ipython to 7.16.x and jedi to 0.17.x to restore Python 3.6 support (ubuntu-bionic-standard) Mar 10, 2021
@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:15

Everything passes on my side and the interface looks as expected.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

comment:16

Also works for me. Positive review from my side.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2021

Changed reviewer from https://github.com/kliem/sage/pull/42/checks to ..., Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

Changed reviewer from ..., Matthias Koeppe to Jonathan Kliem, Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Mar 10, 2021

comment:17

LGTM.

@vbraun
Copy link
Member

vbraun commented Mar 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants