-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade ipython to 7.16.x and jedi to 0.17.x to restore Python 3.6 support (ubuntu-bionic-standard) #31476
Comments
Commit: |
Author: Matthias Koeppe |
Dependencies: #31373 |
comment:4
This ticket breaks it completely. I can't tab-complete anymore and if I try it get and awful error with a hard crash of sage. |
comment:5
Attachment: Sage_crash_report.txt Maybe this reason: ipython/ipython#12740 |
comment:6
Should downgrade jedi to 0.17.0 again. I will open a seperate ticket to address the issues of #31373. |
New commits:
|
Changed author from Matthias Koeppe to Matthias Koeppe, Jonathan Kliem |
comment:11
Shouldn't we use jedi 0.17.2 then? |
comment:12
Yes. I just didn't check and assumed that 0.17.0 is below 0.18.0. 0.17.2 mentions python 3.9 support, so that's a plus. |
New commits:
|
comment:15
Everything passes on my side and the interface looks as expected. |
comment:16
Also works for me. Positive review from my side. |
Changed reviewer from https://github.com/kliem/sage/pull/42/checks to ..., Matthias Koeppe |
Changed reviewer from ..., Matthias Koeppe to Jonathan Kliem, Matthias Koeppe |
comment:17
LGTM. |
(from #31373)
Depends on #31373
CC: @kliem
Component: packages: standard
Author: Matthias Koeppe, Jonathan Kliem
Branch/Commit:
50084a8
Reviewer: Jonathan Kliem, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/31476
The text was updated successfully, but these errors were encountered: