-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies of ipywidgets #31523
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
New commits:
|
Author: Matthias Koeppe |
Reviewer: Jonathan Kliem |
comment:6
LGTM. |
comment:7
Thank you. |
comment:8
Setting priority to blocker to bring this ticket to the attention of the release bot. |
Changed branch from u/mkoeppe/fix_dependencies_of_ipywidgets to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #31278, which removed heavy dependencies from
widgetsnbextension
(which is a dependency ofipywidgets
), we have to add some (lighter) dependencies toipywidgets
.https://github.com/jupyter-widgets/ipywidgets/blob/master/setup.cfg#L35
lists:
These are not reflected in our
dependency
file. In this ticket we add the first three. (nbformat
is only there so as to rule out some broken versions; we do not needjupyterlab_...
.)So far this has not caused a build failure, but it is possible that one could appear in heavily parallelized builds.
The missing dependency is visible in the testsuite run for optional package
p_group_cohomology
in https://github.com/mkoeppe/sage/runs/2145415988CC: @dimpase @kliem @simon-king-jena @slel
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
94fd11f
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/31523
The text was updated successfully, but these errors were encountered: