Failure when testing sage_conf version

[vbraun]

I don't know why its important that sage_conf version is 'none', but it sometimes fails with the actual version number after doing some incremental builds:

sage -t --long --warn-long 46.6 --random-seed=0 src/sage/misc/package.py
**********************************************************************
File "src/sage/misc/package.py", line 359, in sage.misc.package.installed_packages
Failed example:
    installed_packages()['sage_conf']  # optional - build
Expected:
    'none'
Got:
    '9.3'
**********************************************************************

Depends on #30913

CC: @jhpalmieri @dimpase @slel

Component: build

Author: Matthias Koeppe

Branch: fea1f4e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31825

[mkoeppe]

comment:1

This test is changed in #29013.

[mkoeppe]

Dependencies: #29013

[vbraun]

comment:2

Wrong ticket? the test doesn't appear to be changed in #29013 & failure persists with it

[mkoeppe]

Changed dependencies from #29013 to #30913

[mkoeppe]

comment:3

Sorry for the confusion. The version for sage_conf was introduced in #30913, and the fix of the doctest appears in #31577. I am going to cherry-pick from there.

[mkoeppe]

Branch: u/mkoeppe/failure_when_testing_sage_conf_version

[mkoeppe]

Last 10 new commits:

66c2987	build/pkgs/{sage_sws2rst,sage_docbuild}/install-requires.txt: New
7f8ec6c	build/pkgs/sagelib/src/tox.ini: Add factor sitepackages
0283da5	build/make/Makefile.in: Add wheel, setuptools_wheel to PYTHON_TOOLCHAIN to make sure that PEP 517 packages have a complete build system
f720722	build/pkgs/sagelib/src/tox.ini: Add factor nobuildisolation
c451b31	src/setup.cfg.m4 (install_requires): Add sage_conf
6700223	Merge tag '9.3.rc0' into t/30913/sagelib__add_setup_cfg__install_requires_
04da2c6	build/pkgs/ipywidgets: Patch out declaring install-requires of nbformat and jupyterlab-widgets
5b75105	Merge #30913
e8540a9	src/sage/misc/package.py: sage_conf now has a version
fea1f4e	src/sage/misc/package.py: Better doctest for installed_packages

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: fea1f4e

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:7

lgtm

[mkoeppe]

comment:8

Thanks!

[vbraun]

Changed branch from u/mkoeppe/failure_when_testing_sage_conf_version to fea1f4e

[fchapoton]

comment:10

now we have

sage -t --long --random-seed=0 src/sage/misc/package.py
**********************************************************************
File "src/sage/misc/package.py", line 359, in sage.misc.package.installed_packages
Failed example:
    installed_packages()['sage_conf'] == sage.env.SAGE_VERSION # optional - build
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of   4 in sage.misc.package.installed_packages
    [52 tests, 1 failure, 3.07 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/misc/package.py  # 1 doctest failed

[fchapoton]

Changed commit from fea1f4e to none

[vbraun]

comment:11

I think thats whenever you do an incremental build over a Sage version release. Followup at #31928