Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin patch for Singular #32257

Closed
mkoeppe opened this issue Jul 21, 2021 · 13 comments
Closed

Cygwin patch for Singular #32257

mkoeppe opened this issue Jul 21, 2021 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 21, 2021

As noted in #32001 comment:1, pynac fails on cygwin-standard. We add a patch to singular to fix this

Singular/Singular#1109 (merged)

CC: @vbraun @dimpase @slel

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: d4156f7

Reviewer: Dima Pasechnik, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/32257

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 21, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2021

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2021

Branch: u/mkoeppe/cygwin_patch_for_singular

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2021

comment:4

This does the job.


New commits:

d4156f7build/pkgs/singular/patches/0001-factory-canonicalform.h-Add-more-FACTORY_PUBLIC.patch: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2021

Commit: d4156f7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 21, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jul 21, 2021

comment:5

OK, great.

@dimpase
Copy link
Member

dimpase commented Jul 21, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1051039345 to Dima Pasechnik

@slel
Copy link
Member

slel commented Jul 22, 2021

comment:6

I applied this locally on Cygwin on Windows 10.
It works and makes #32001 work.

I'm curious how you figured out those changes
would solve this problem! Thank you!

@slel
Copy link
Member

slel commented Jul 22, 2021

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Samuel Lelièvre

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 22, 2021

comment:7

Thanks for testing! The fix was just an extension of one that Hans Schoenemann did earlier this year to get Cygwin working.

@vbraun
Copy link
Member

vbraun commented Jul 24, 2021

Changed branch from u/mkoeppe/cygwin_patch_for_singular to d4156f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants