Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear out __init__.py in sage.rings.polynomial #32509

Closed
mkoeppe opened this issue Sep 13, 2021 · 8 comments
Closed

Clear out __init__.py in sage.rings.polynomial #32509

mkoeppe opened this issue Sep 13, 2021 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 13, 2021

sage.rings.polynomial (and all of sage.rings) has lots of Cython modules that depend on various C/C++ libraries and will have to go into different distribution packages (#29705, #32501).

Thus we need to clear out __init__.py, which currently contains a workaround added in #25848 ("Some preparations for binding=True") in preparation for #22747/#26254. As this effort has stalled, we remove this workaround; a new solution can be found when #26254 gains traction again.

CC: @fchapoton @tscrim @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: c41e11c

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/32509
@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 13, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2021

Branch: u/mkoeppe/clear_out___init___py_in_sage_rings_polynomial

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2021

Commit: c41e11c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2021

New commits:

c41e11csrc/sage/rings/polynomial/__init__.py: Remove cyclic-import workaround, not needed currently

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mezzarobba
Copy link
Member

comment:3

Looks like a trivial change that won't hurt.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 18, 2021

comment:4

Thanks.

@vbraun
Copy link
Member

vbraun commented Sep 25, 2021

Changed branch from u/mkoeppe/clear_out___init___py_in_sage_rings_polynomial to c41e11c

@vbraun vbraun closed this as completed in 8ff66b7 Sep 25, 2021
@kwankyu kwankyu mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @mezzarobba @mkoeppe