flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2 #32707

`8bcbf1d`	`Makefile (distclean): Remove convenience symlinks prefix, venv`
`dcb4a08`	`configure.ac: Indicate default in help string for --with-sage-venv`
`e33bc89`	`Merge tag '9.5.beta3' into t/32442/__configure__make___with_sage_venv_the_default`
`2101b8c`	`build/pkgs/python3/spkg-build.in: Make sure that python finds sqlite3 when determining which extension modules to build`
`3bbc5d8`	`build/pkgs/python3/spkg-build.in: Set rpath`
`99f0a5f`	`Merge #32698`
`7100660`	`build/pkgs/backcall/dependencies: flit_core now uses tomli`
`0f5158f`	`build/pkgs/setuptools_scm: Update to 6.3.2`
`e053097`	`build/pkgs/importlib_metadata/dependencies: setuptools_scm[toml] uses tomli now`
`ed0b42b`	`build/pkgs/toml: Remove`

mkoeppe · 2021-10-17T17:58:30Z

Changed dependencies from #32698, #32492 to #32698

sagetrac-git · 2021-10-17T18:03:03Z

Changed commit from ed0b42b to 4720666

sagetrac-git · 2021-10-17T18:03:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4720666`	`build/pkgs/tomli/spkg-install.in: Set up PYTHONPATH`

vbraun · 2021-10-17T22:46:56Z

comment:8

Is this the expected output?

ERROR: Could not find a version that satisfies the requirement tomli (from flit-core) (from versions: none)
ERROR: No matching distribution found for tomli
Warning: installing with "python3 -m pip install --verbose --no-index --find-links=/home/release/Sage/local/var/lib/sage/venv-python3.9/var/lib/sage/wheels --disable-pip-version-check --isolated --no-cache-dir" failed. Retrying, adding "--no-deps --ignore-installed --ignore-requires-python"
Using pip 21.2.4 from /home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/pip (python 3.9)
Looking in links: /home/release/Sage/local/var/lib/sage/venv-python3.9/var/lib/sage/wheels
Processing /home/release/Sage/local/var/lib/sage/venv-python3.9/var/tmp/sage/build/flit_core-3.4.0/inst/home/release/Sage/local/var/lib/sage/venv-python3.9/var/lib/sage/wheels/flit_core-3.4.0-py3-none-any.whl
Installing collected packages: flit-core
Successfully installed flit-core-3.4.0
Warning: The installation needed to use "--no-deps --ignore-installed --ignore-requires-python" to succeed. This means that a dependencies file in build/pkgs/ needs to be updated. Please report this to [email protected], including the build log of this package.

vbraun · 2021-10-17T22:48:05Z

comment:9

tox still depends on toml:

build/pkgs/tox/dependencies:$(PYTHON) packaging six filelock pluggy py toml virtualenv importlib_metadata | $(PYTHON_TOOLCHAIN)

mkoeppe · 2021-10-17T23:29:53Z

comment:10

Replying to @vbraun:

Is this the expected output?

Warning: The installation needed to use "--no-deps --ignore-installed --ignore-requires-python" to succeed. This means that a dependencies file in build/pkgs/ needs to be updated. Please report this to [email protected], including the build log of this package.

Yes

sagetrac-git · 2021-10-17T23:33:43Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`fa561b2`	`build/pkgs/tomli/spkg-install.in: Set up PYTHONPATH`
`9eea50c`	`build/pkgs/toml/spkg-configure.m4: If system tox is used, mark as not required`

sagetrac-git · 2021-10-17T23:33:43Z

Changed commit from 4720666 to 9eea50c

mkoeppe · 2021-10-17T23:34:19Z

comment:12

Replying to @vbraun:

tox still depends on toml:

build/pkgs/tox/dependencies:$(PYTHON) packaging six filelock pluggy py toml virtualenv importlib_metadata | $(PYTHON_TOOLCHAIN)

Thanks for catching this

vbraun · 2021-10-18T20:25:05Z

comment:15

Ok its a bit sub-optimal to tell people to complain on sage-devel upon successful installation, but hopefully nobody looks into the log.

However, building the source tarball fails because tox still depends on toml:

sage -sdist
[...]
[threejs-r122.p0] Using cached file /home/release/Sage/upstream/threejs-sage-r122.tar.gz
make[1]: Nothing to be done for 'tomli'.
make[1]: Nothing to be done for 'tornado'.
make[1]: *** No rule to make target 'toml', needed by '/home/release/Sage/local/var/lib/sage/venv-python3.9/var/lib/sage/installed/tox-3.24.3'.  Stop.
make: *** [Makefile:2336: download-for-sdist] Error 2

mkoeppe · 2021-10-18T20:52:59Z

comment:16

Did you run bootstrap?

vbraun · 2021-10-18T20:54:16Z

comment:17

Yes, did run bootstrap. The content of the source tarball hopefully doesn't depend on which system libraries are available.

Also just got this while trying the latest version

****************************************************
Uninstalling existing 'pyparsing'
Warning: File '/home/release/Sage/local/var/lib/sage/wheels/pyparsing-2.4.7-py2.py3-none-any.whl' not found
Warning: Directory '/home/release/Sage/local/var/lib/sage/wheels' not found
Running pip-uninstall script for 'pyparsing'
Found existing installation: pyparsing 2.4.7
Uninstalling pyparsing-2.4.7:
  Successfully uninstalled pyparsing-2.4.7
Removing stamp file '/home/release/Sage/local/var/lib/sage/venv-python3.9/var/lib/sage/installed/pyparsing-2.4.7'
Installing pyparsing-2.4.7
Processing /home/release/Sage/local/var/lib/sage/venv-python3.9/var/tmp/sage/build/pyparsing-2.4.7/src
    Running command python setup.py egg_info
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/var/tmp/sage/build/pyparsing-2.4.7/src/setup.py", line 18, in <module>
        setup(# Distribution meta-data
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/setuptools/__init__.py", line 153, in setup
        return distutils.core.setup(**attrs)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/setuptools/_distutils/core.py", line 108, in setup
        _setup_distribution = dist = klass(attrs)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/setuptools/dist.py", line 450, in __init__
        _Distribution.__init__(
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/setuptools/_distutils/dist.py", line 293, in __init__
        self.finalize_options()
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/setuptools/dist.py", line 827, in finalize_options
        for ep in sorted(loaded, key=by_order):
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/setuptools/dist.py", line 826, in <lambda>
        loaded = map(lambda e: e.load(), filtered)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/pkg_resources/__init__.py", line 2449, in load
        self.require(*args, **kwargs)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/pkg_resources/__init__.py", line 2472, in require
        items = working_set.resolve(reqs, env, installer, extras=self.extras)
      File "/home/release/Sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/pkg_resources/__init__.py", line 772, in resolve
        raise DistributionNotFound(req, requirers)
    pkg_resources.DistributionNotFound: The 'tomli>=1.0.0' distribution was not found and is required by the application
WARNING: Discarding file:///home/release/Sage/local/var/lib/sage/venv-python3.9/var/tmp/sage/build/pyparsing-2.4.7/src. Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
**************************************************************************************************************************************************************
Error building a wheel for pyparsing-2.4.7
**************************************************************************************************************************************************************

mkoeppe · 2021-10-18T21:00:04Z

comment:18

Replying to @vbraun:

Ok its a bit sub-optimal to tell people to complain on sage-devel upon successful installation, but hopefully nobody looks into the log.

Yes, we can address this in #32715.

mkoeppe · 2021-10-18T21:06:55Z

comment:19

Replying to @vbraun:

Yes, did run bootstrap. The content of the source tarball hopefully doesn't depend on which system libraries are available.

Asking because it looks like what a make run would look like after the toml package has been removed.

mkoeppe · 2021-10-18T21:12:32Z

comment:20

I recommend to use make dist instead of directly using ./sage --sdist, which takes care of regenerating the Makefile.

mkoeppe · 2021-10-18T21:24:24Z

comment:21

Replying to @vbraun:

Also just got this while trying the latest version

****************************************************
Uninstalling existing 'pyparsing'
Warning: File '/home/release/Sage/local/var/lib/sage/wheels/pyparsing-2.4.7-py2.py3-none-any.whl' not found
Warning: Directory '/home/release/Sage/local/var/lib/sage/wheels' not found
Running pip-uninstall script for 'pyparsing'
Found existing installation: pyparsing 2.4.7

Best to get rid of this messed up worktree

vbraun · 2021-10-18T22:46:12Z

comment:22

The pyparsing error says that tomli is required, but its not listed as a dependency

[release@zen Sage]$ cat build/pkgs/pyparsing/dependencies 
$(PYTHON) | setuptools pip wheel

I think thats a real dependency error

mkoeppe · 2021-10-18T22:50:04Z

comment:23

There's nothing in pyparsing that refers to tomli.

I think in your worktree, you have for some reason a broken installation record of pip packages.

Can you reproduce this in a from scratch build?

vbraun · 2021-10-19T20:29:13Z

Reviewer: Volker Braun

vbraun · 2021-10-19T20:30:37Z

Changed branch from u/mkoeppe/flit_core__update_to_3_4_0 to 9eea50c

vbraun · 2021-10-24T08:48:46Z

comment:26

I'm still getting very frequent pkg_resources.DistributionNotFound: The 'xxx>=20.0' distribution was not found and is required by the application errors with incremental builds with some packaging-related pip packages. Basically have to do a make distclean every day now. Something is messed up there...

vbraun · 2021-10-24T08:48:46Z

Changed commit from 9eea50c to none

vbraun · 2021-10-24T09:13:47Z

comment:27

I've created #32751 for this issue

vbraun · 2021-11-07T10:09:41Z

comment:28

The issue is not fixed, I still see very frequent pkg_resources.DistributionNotFound: The 'xxx>=20.0' distribution was not found and is required by the application errors during incremental builds

mkoeppe added this to the sage-9.5 milestone Oct 17, 2021

mkoeppe added c: packages: standard labels Oct 17, 2021

mkoeppe changed the title ~~flit_core: Update to 3.4.0~~ flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2; remove package toml Oct 17, 2021

mkoeppe added the s: needs review label Oct 17, 2021

mkoeppe changed the title ~~flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2; remove package toml~~ flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2 Oct 17, 2021

This comment has been minimized.

Sign in to view

vbraun added s: positive review and removed s: needs review labels Oct 19, 2021

vbraun removed the s: positive review label Oct 19, 2021

vbraun closed this as completed in e8ab458 Oct 19, 2021

mkoeppe mentioned this issue Dec 5, 2021

Update pip to 21.3.1, distlib to 0.3.3 #32671

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2 #32707

flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2 #32707

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

vbraun commented Oct 17, 2021

vbraun commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

This comment has been minimized.

vbraun commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

vbraun commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

vbraun commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

vbraun commented Oct 19, 2021

vbraun commented Oct 19, 2021

vbraun commented Oct 24, 2021

vbraun commented Oct 24, 2021

vbraun commented Oct 24, 2021

vbraun commented Nov 7, 2021

flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2 #32707

flit_core: Update to 3.4.0; setuptools_scm: Update to 6.3.2 #32707

Comments

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

vbraun commented Oct 17, 2021

vbraun commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

sagetrac-git mannequin commented Oct 17, 2021

mkoeppe commented Oct 17, 2021

This comment has been minimized.

vbraun commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

vbraun commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

vbraun commented Oct 18, 2021

mkoeppe commented Oct 18, 2021

vbraun commented Oct 19, 2021

vbraun commented Oct 19, 2021

vbraun commented Oct 24, 2021

vbraun commented Oct 24, 2021

vbraun commented Oct 24, 2021

vbraun commented Nov 7, 2021