Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.features, sage_setup: Replace use of distutils.errors by setuptools #32873

Closed
mkoeppe opened this issue Nov 15, 2021 · 8 comments
Closed

sage.features, sage_setup: Replace use of distutils.errors by setuptools #32873

mkoeppe opened this issue Nov 15, 2021 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 15, 2021

setuptools.errors available since https://setuptools.pypa.io/en/latest/history.html#v59-0-0

See https://github.com/pypa/setuptools/pull/2858/files

CC: @kiwifb @antonio-rojas @tornaria

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1c83bcd

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/32873
@mkoeppe mkoeppe added this to the sage-9.5 milestone Nov 15, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 15, 2021

Branch: u/mkoeppe/sage_features__sage_setup__replace_use_of_distutils_errors_by_setuptools

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 15, 2021

Commit: 1c83bcd

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 15, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 15, 2021

New commits:

f211926src/sage_setup/command/sage_build_ext.py: Try import from setuptools.errors before distutils.errors
1c83bcdsrc/sage/features/__init__.py: Try import from setuptools.errors before distutils.errors

@kiwifb
Copy link
Member

kiwifb commented Dec 21, 2021

comment:4

That's a rather trivial change. A cursory check shows that those are all the one that can be replaced.

@kiwifb
Copy link
Member

kiwifb commented Dec 21, 2021

Reviewer: François Bissey

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 21, 2021

comment:5

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 28, 2022
@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/mkoeppe/sage_features__sage_setup__replace_use_of_distutils_errors_by_setuptools to 1c83bcd

@vbraun vbraun closed this as completed in c85d230 Jan 31, 2022
This was referenced Jan 7, 2023
Open
Closed
@tornaria tornaria mentioned this issue Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@kiwifb @vbraun @mkoeppe