Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with Python 3.10 #33013

Closed
antonio-rojas opened this issue Dec 12, 2021 · 11 comments
Closed

Fix tests with Python 3.10 #33013

antonio-rojas opened this issue Dec 12, 2021 · 11 comments

Comments

@antonio-rojas
Copy link
Contributor

Assorted Python 3.10 test fixes. See individual commit messages for details.

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: 2f13b86

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33013

@antonio-rojas antonio-rojas added this to the sage-9.5 milestone Dec 12, 2021
@antonio-rojas
Copy link
Contributor Author

Branch: u/arojas/fix_tests_with_python_3_10

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 12, 2021

Commit: f345263

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 12, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

27fbff0Assign module property to test class
26c9b33Add abs tol to some tests to make them pass with Python 3.10
079cecaAdd missing space
6603e29Update some error messages to match Python 3.10 format
f345263Make sure the timeout passed to select.select is a float

@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@antonio-rojas

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 12, 2021

Changed commit from f345263 to 2f13b86

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 12, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2f13b86Update another error message for Python 3.10

@enriqueartal
Copy link
Contributor

comment:5

Running tests in Fedora 35 on this branch merged with develop and #32576, most of the failures are gone. The timed out failure is also gone if applied directly.

sage -t --warn-long 36.2 --random-seed=242830779982902445975789228198447399241 src/sage/schemes/curves/affine_curve.py  # Timed out
sage -t --warn-long 36.2 --random-seed=242830779982902445975789228198447399241 src/sage/env.py  # 1 doctest failed
sage -t --warn-long 36.2 --random-seed=242830779982902445975789228198447399241 src/sage/interfaces/singular.py  # 3 doctests failed
sage -t --warn-long 36.2 --random-seed=242830779982902445975789228198447399241 src/sage/libs/giac/__init__.py  # 7 doctests failed

@enriqueartal
Copy link
Contributor

comment:6

I apologize for the noise; by some reason it was built with python 3.9. Building again with 3.10, these were the failures:

sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/tests/cmdline.py  # Timed out (and interrupt failed)
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/interfaces/expect.py  # 2 doctests failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/interfaces/sage0.py  # 1 doctest failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage_docbuild/utils.py  # 2 doctests failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/quivers/algebra_elements.pxi  # 1 doctest failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/interfaces/singular.py  # 3 doctests failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/libs/giac/__init__.py  # 7 doctests failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/interfaces/psage.py  # 1 doctest failed
sage -t --warn-long 39.5 --random-seed=28222279427542019315582234305463069698 src/sage/cpython/atexit.pyx  # 6 doctests failed

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 17, 2021

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Dec 23, 2021

Changed branch from u/arojas/fix_tests_with_python_3_10 to 2f13b86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants