Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib to 3.5 #33040

Closed
mkoeppe opened this issue Dec 17, 2021 · 20 comments
Closed

Update matplotlib to 3.5 #33040

mkoeppe opened this issue Dec 17, 2021 · 20 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Dec 17, 2021

Previous update: #31580

Depends on #31580

CC: @dimpase @kiwifb @antonio-rojas @tornaria

Component: packages: standard

Author: Matthias Koeppe

Branch: 41de5fe

Reviewer: François Bissey, Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/33040

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 17, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 18, 2021

Branch: u/mkoeppe/update_matplotlib_to_3_5

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 18, 2021

Last 10 new commits:

00b677bnew dep of kiwisolver, cppy
48b7ec3update matplotlib deps
26910e6fix SPKG.rst's for cppy and kiwisolver
aedaf93Revert "add gfortran to _prereq/distros/*"
62792d4use pypi host for cycler url
3201af7Merge #31580
6d203ebbuild/pkgs/matplotlib: Update to 3.5.1
5a68988build/pkgs/matplotlib/make-setup-config.py: Write mplsetup.cfg, not setup.cfg
767092bbuild/pkgs/matplotlib/dependencies: Update dependencies
9b5a663build/pkgs/setuptools_scm_git_archive: New, matplotlib dependency

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 18, 2021

Commit: 9b5a663

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 18, 2021

Author: Matthias Koeppe

@kiwifb
Copy link
Member

kiwifb commented Dec 18, 2021

comment:3

According to the gentoo ebuild for 3.5.1 there should be another new runtime dependency https://pypi.org/project/fonttools/ although it may work without it for all I know.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Changed commit from 9b5a663 to d865a54

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d865a54build/pkgs/fonttools: New

@tornaria
Copy link
Contributor

comment:5

Looks good to me, and it solves the issue with deprecated distutils and python 3.10.

@kiwifb
Copy link
Member

kiwifb commented Dec 20, 2021

comment:7

My changes to qhull in #31580 need to be merged here.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

0018e34Merge branch 'develop' into MPL3_4
0e5c130Specify custom variable LIB_INSTALL_DIR for qhull, it controls rpath and install_name settings on OSX
475a26abuild/pkgs/cppy/install-requires.txt: New
41de5feMerge #31580

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2021

Changed commit from d865a54 to 41de5fe

@kiwifb
Copy link
Member

kiwifb commented Dec 20, 2021

comment:9

LGTM

@kiwifb
Copy link
Member

kiwifb commented Dec 20, 2021

Reviewer: François Bissey

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 20, 2021

comment:10

Thanks!

@egourgoulhon
Copy link
Member

comment:11

Just to tell that I've tested the update on a few notebooks involving various matplotlib plots, either via Sage graphics or via direct use of matplotlib. Everything is OK. Thanks for the update!

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 21, 2021

comment:12

Thanks for testing!

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 21, 2021

Changed reviewer from François Bissey to François Bissey, Eric Gourgoulhon

@vbraun
Copy link
Member

vbraun commented Dec 28, 2021

Changed branch from u/mkoeppe/update_matplotlib_to_3_5 to 41de5fe

@mezzarobba
Copy link
Member

comment:15

New warning after this upgrade (or possibly that to 3.4?):

sage: list_plot([0], marker='x')
/home/marc/co/sage/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/sage/plot/point.py:288: UserWarning: You passed a edgecolor/edgecolors ('none') for an unfilled marker ('x').  Matplotlib is ignoring the edgecolor in favor of the facecolor.  This behavior may change in the future.
  subplot.scatter(self.xdata, self.ydata, s=s, c=c, alpha=a, zorder=z,

@mezzarobba
Copy link
Member

Changed commit from 41de5fe to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants