Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml: In workflow_dispatch, make container and base tag selectable; add doc #33819

Closed
mkoeppe opened this issue May 7, 2022 · 29 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 7, 2022

as done in https://github.com/sagemath/sage-patchbot/blob/master/.github/workflows/run_patchbot.yml

We also add some documentation to the developer's guide.

Depends on #34104
Depends on #33873
Depends on #34092

CC: @tobiasdiez @fchapoton @kwankyu @dimpase

Component: user interface

Author: Matthias Koeppe

Branch/Commit: 1f00ee3

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33819

@mkoeppe mkoeppe added this to the sage-9.7 milestone May 7, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

Dependencies: #34104

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

Changed dependencies from #34104 to #34104, #33873

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Commit: 99375cd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

99375cd.github/workflows/build.yml: In workflow_dispatch, make container and base tag selectable

@tobiasdiez
Copy link
Contributor

comment:6

With these changes the normal workflow triggered by a push doesn't seem to work anymore since the fallback is not used, i.e. the workflow tries to get ghcr.io/sagemath/sage/sage-docker--with-targets which obviously doesn't work: https://github.com/sagemath/sagetrac-mirror/runs/7173656912?check_suite_focus=true

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

comment:7

Ah, thanks for catching this

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6b594c9.github/workflows/build.yml: Use defaults for 'push' invocations

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Changed commit from 99375cd to 6b594c9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

31336e0.github/workflows/build.yml: Use defaults for 'push' invocations

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Changed commit from 6b594c9 to 31336e0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Changed commit from 31336e0 to 78eda9b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

78eda9bsrc/doc/en/developer/trac.rst: Merge material from https://trac.sagemath.org/wiki/ReleaseTours/sage-9.6\#BuildsandchecksofticketbranchesonGitHubActions

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title build.yml: In workflow_dispatch, make container and base tag selectable build.yml: In workflow_dispatch, make container and base tag selectable; add doc Jul 4, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 6, 2022

Changed dependencies from #34104, #33873 to #34104, #33873, #34092

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2022

Changed commit from 78eda9b to 5d6a75c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

889fcc1Revert "Use furo on ci"
5d6a75cMerge #34092

@dimpase
Copy link
Member

dimpase commented Jul 6, 2022

comment:17

docs build only after applying

--- a/src/doc/en/developer/trac.rst
+++ b/src/doc/en/developer/trac.rst
@@ -288,9 +288,8 @@ After pushing a branch to a ticket, the ticket will show badges
 linking to results of automated tests that run on the patchbot and
 other ​tests that run on GitHub Actions.
 
-* The Patch buildbot will automatically test your ticket. See `the
-  patchbot wiki <https://trac.sagemath.org/wiki/patchbot>`_ for more
-  information about its features and limitations. Make sure that you
+* The Patch buildbot will automatically test your ticket. See :trac:`wiki/patchbot`
+  for more information about its features and limitations. Make sure that you
   look at the log, especially if the patch buildbot did not give you
   the green blob.
 

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 6, 2022

comment:19

Thanks, can you push the change to the ticket please?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 7, 2022

Changed commit from 5d6a75c to c223368

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c223368src/doc/en/developer/trac.rst: Fix markup

@dimpase
Copy link
Member

dimpase commented Jul 7, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 7, 2022

comment:22

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 7, 2022

comment:23

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 10, 2022

comment:24

PDF docs don't build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bce301eMerge tag '9.7.beta4' into t/33819/build_yml__in_workflow_dispatch__make_container_and_base_tag_selectable
1f00ee3src/doc/en/developer/trac.rst: Remove stray unicode

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 10, 2022

Changed commit from c223368 to 1f00ee3

@vbraun
Copy link
Member

vbraun commented Jul 11, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants