-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.yml: In workflow_dispatch, make container and base tag selectable; add doc #33819
Comments
Dependencies: #34104 |
Author: Matthias Koeppe |
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:6
With these changes the normal workflow triggered by a push doesn't seem to work anymore since the fallback is not used, i.e. the workflow tries to get |
comment:7
Ah, thanks for catching this |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:17
docs build only after applying --- a/src/doc/en/developer/trac.rst
+++ b/src/doc/en/developer/trac.rst
@@ -288,9 +288,8 @@ After pushing a branch to a ticket, the ticket will show badges
linking to results of automated tests that run on the patchbot and
other tests that run on GitHub Actions.
-* The Patch buildbot will automatically test your ticket. See `the
- patchbot wiki <https://trac.sagemath.org/wiki/patchbot>`_ for more
- information about its features and limitations. Make sure that you
+* The Patch buildbot will automatically test your ticket. See :trac:`wiki/patchbot`
+ for more information about its features and limitations. Make sure that you
look at the log, especially if the patch buildbot did not give you
the green blob.
|
comment:19
Thanks, can you push the change to the ticket please? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Dima Pasechnik |
comment:22
lgtm |
comment:23
Thanks! |
comment:24
PDF docs don't build |
Changed branch from u/mkoeppe/build_yml__in_workflow_dispatch__make_container_and_base_tag_selectable to |
as done in https://github.com/sagemath/sage-patchbot/blob/master/.github/workflows/run_patchbot.yml
We also add some documentation to the developer's guide.
Depends on #34104
Depends on #33873
Depends on #34092
CC: @tobiasdiez @fchapoton @kwankyu @dimpase
Component: user interface
Author: Matthias Koeppe
Branch/Commit:
1f00ee3
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33819
The text was updated successfully, but these errors were encountered: