Add missing cdef method declarations (for Cython 3)

[mkoeppe]

from #29863 comment:15

CC: @tscrim @kwankyu @tobiasdiez

Component: cython

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/add_missing_cdef_method_declarations__for_cython_3_ @ 9d89bdf

Issue created by migration from https://trac.sagemath.org/ticket/34257

[mkoeppe]

Branch: u/mkoeppe/add_missing_cdef_method_declarations__for_cython_3_

[mkoeppe]

New commits:

1f9ee80	src/sage/libs/lcalc/lcalc_Lfunction.pxd: Add missing cdef method declarations
034094c	src/sage/matroids/{basis,linear}_matroid.pxd: Add missing cdef method declarations
9d89bdf	src/sage/rings/polynomial/polynomial_element.pxd: Add missing cdef method declaration

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 9d89bdf

[tscrim]

comment:3

I am very surprised that Cython will require subclasses to redeclare things in the base class with the same signature. This seems quite pointless and likely to have a number of changes in the Sage library. Well, if it is what it is, then we will have to do it, but it is a departure from C++. You think you got every one here?

[mkoeppe]

comment:4

Replying to @tscrim:

You think you got every one here?

Yes, as tested with #29863

[tscrim]

comment:5

Build failure; see patchbot.

[mkoeppe]

comment:6

Indeed

[sagelib-9.7.beta6] Error compiling Cython file:
[sagelib-9.7.beta6] ------------------------------------------------------------
[sagelib-9.7.beta6] ...
[sagelib-9.7.beta6]             tmpi=Integer(dirichlet_coeff[i])
[sagelib-9.7.beta6]             coeffs[i+1] = mpz_get_si(tmpi.value)
[sagelib-9.7.beta6]         self.thisptr=new_c_Lfunction_I(NAME, what_type,  N, coeffs, Period, q,  w,  A, g, l, n_poles, p, r)
[sagelib-9.7.beta6]         del_ints(coeffs)
[sagelib-9.7.beta6] 
[sagelib-9.7.beta6]     cdef inline c_Complex __value(self,c_Complex s,int derivative):
[sagelib-9.7.beta6]         ^
[sagelib-9.7.beta6] ------------------------------------------------------------
[sagelib-9.7.beta6] 
[sagelib-9.7.beta6] sage/libs/lcalc/lcalc_Lfunction.pyx:510:9: Overriding final methods is not allowed
[sagelib-9.7.beta6] 

[mkoeppe]

comment:7

Help by Cython experts is needed to find a solution that works with both Cython 0.29.x and Cython 3

[mkoeppe]

Closing this; @tornaria describes a proper solution in #29863 (comment)