Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_Polyhedron, is_Cone, is_LatticePolytope #34307

Closed
mkoeppe opened this issue Aug 8, 2022 · 1 comment · Fixed by #37057
Closed

Deprecate is_Polyhedron, is_Cone, is_LatticePolytope #34307

mkoeppe opened this issue Aug 8, 2022 · 1 comment · Fixed by #37057
Labels
c: geometry good first issue p: minor / 4 t: enhancement t: refactoring
Milestone
sage-10.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 8, 2022

... and change all uses to isinstance(sage.geometry.abc.Polyhedron) etc.

(see #32414)

CC: @yuan-zhou @jplab @NicoleYueqiLi

Component: geometry

Issue created by migration from https://trac.sagemath.org/ticket/34307
@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 8, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
This was referenced Jan 13, 2024
Closed
Merged
@Veeransh14
Copy link

I would Like to work on this Issue

@vbraun vbraun closed this as completed in 90e08c8 May 2, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry good first issue p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.4
2 participants
@mkoeppe @Veeransh14