Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage --package create: Add option --source wheel #34454

Closed
mkoeppe opened this issue Aug 30, 2022 · 11 comments
Closed

sage --package create: Add option --source wheel #34454

mkoeppe opened this issue Aug 30, 2022 · 11 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 30, 2022

Utility for creating wheel packages (#34450)

CC: @kwankyu @dimpase @jhpalmieri @sagetrac-tmonteil

Component: build

Author: Matthias Koeppe

Branch/Commit: d18cfa4

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34454

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 30, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 30, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 30, 2022

Commit: 3abd029

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 30, 2022

New commits:

3abd029sage --package create: Add option --source wheel

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 30, 2022

Author: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Sep 26, 2022

comment:5
  1. Would you add one or two examples to sage_bootstrap.app.create like other methods?

  2. In sage_bootstrap.creator.set_python_data_and_scripts(), the raise statement at the end needs to be edited. In its docstring, wheel case needs to be added.

  3. In sage_bootstrap.pypi.PyPiVersion.url, there is unnecessary print statement (for debugging?)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

00d2171sage --package create: Add option --source wheel
1a31a6abuild/sage_bootstrap/pypi.py: Remove debugging code
2efa318build/sage_bootstrap/creator.py (set_python_data_and_scripts): Update docstring and exception message
d18cfa4build/sage_bootstrap/app.py, src/doc/en/developer/packaging.rst: Add doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2022

Changed commit from 3abd029 to d18cfa4

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 26, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 26, 2022

comment:7

Thanks for the examples.

It works well. It looks good to me.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 26, 2022

comment:8

Thank you!

@vbraun
Copy link
Member

vbraun commented Sep 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants