Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions portability workflows: Use SAGE_FAT_BINARY=yes #34572

Closed
mkoeppe opened this issue Sep 23, 2022 · 9 comments
Closed

GH Actions portability workflows: Use SAGE_FAT_BINARY=yes #34572

mkoeppe opened this issue Sep 23, 2022 · 9 comments
Labels
c: porting p: major / 3 t: bug
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 23, 2022

This will make the 2-stage builds from #33062 more robust (see #33816 comment:60) and will make the
devcontainer feature based on the portability images (https://trac.sagemath.org/wiki/ReleaseTours/sage-9.7#VisualStudioCodedevcontainers) more useful.

CC: @dimpase @tobiasdiez @jhpalmieri

Component: porting

Author: Matthias Koeppe

Branch/Commit: 9696b34

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34572
@mkoeppe mkoeppe added this to the sage-9.8 milestone Sep 23, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 14, 2022

Branch: u/mkoeppe/gh_actions_portability_workflows__use_sage_fat_binary_yes

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 14, 2022

New commits:

9696b34.github/workflows/docker.yml: Use EXTRA_CONFIGURE_ARGS=--enable-fat-binary

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 14, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 14, 2022

Commit: 9696b34

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2022

comment:3

The sporadic SIGILLs in stage standard are gone - https://github.com/mkoeppe/sage/actions/runs/3251926884

@dimpase
Copy link
Member

dimpase commented Oct 16, 2022

comment:4

OK

@dimpase
Copy link
Member

dimpase commented Oct 16, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 17, 2022

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 17, 2022

Changed branch from u/mkoeppe/gh_actions_portability_workflows__use_sage_fat_binary_yes to 9696b34

@vbraun vbraun closed this as completed in 45fbb67 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe