Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoopRunTest.test_stop fails with libuv 1.45.0+ #279

Open
MeggyCal opened this issue Aug 29, 2023 · 0 comments
Open

LoopRunTest.test_stop fails with libuv 1.45.0+ #279

MeggyCal opened this issue Aug 29, 2023 · 0 comments

Comments

@MeggyCal
Copy link

MeggyCal commented Aug 29, 2023

It passes again with the following changes (but it might not be the correct approach):

Index: pyuv-1.4.0/tests/test_loop.py
===================================================================
--- pyuv-1.4.0.orig/tests/test_loop.py
+++ pyuv-1.4.0/tests/test_loop.py
@@ -48,9 +48,9 @@ class LoopRunTest(TestCase):
         prepare.start(prepare_cb)
         self.loop.run(pyuv.UV_RUN_DEFAULT)
         self.assertEqual(self.timer_called, 1)
-        self.assertTrue(self.prepare_called >= 2)
+        self.assertEqual(self.prepare_called, 1)
         self.loop.run(pyuv.UV_RUN_NOWAIT)
-        self.assertTrue(self.prepare_called >= 3)
+        self.assertEqual(self.prepare_called, 2)
         self.loop.run(pyuv.UV_RUN_DEFAULT)
         self.assertEqual(self.timer_called, 10)
         self.assertEqual(self.prepare_called, 10)

From libuv changelog:

* stream: process more than one write req per loop tick (ywave620)

This could be the problem, but there are more loop changes.

I first observed this failure when updating from libuv 1.44 to 1.46 on openSUSE Tumbleweed (yes, we are using system libuv, I am aware that this is not supported by you). We are running basically the master branch of pyuv and it was working just fine with libuv 1.44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant