Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[Enhancement] Support for Node 14 #42

Open
jgtvares opened this issue Aug 19, 2021 · 1 comment
Open

[Enhancement] Support for Node 14 #42

jgtvares opened this issue Aug 19, 2021 · 1 comment

Comments

@jgtvares
Copy link

Is your feature request related to a problem? Please describe
The lib doesn't support Node 14.
When calling client.dataExtensionRow(...).get(...), the fs library returns an error: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Object.
This is the faulty line:

// CacheService.js
_getOrCreateFile() {
    ...
    return this._writeFile({flag: 'wx'}).then(...)
}

Describe the solution you'd like
Update the lib to support Node 14.

Describe alternatives you've considered
Changing the _writeFile method to something like this: _writeFile("wx") works fine!
That's because newer version of fs expects a string for file content.

Additional context
Add any other context or screenshots about the feature request here.

@DougMidgley
Copy link

Feel free to check out https://www.npmjs.com/package/sfmc-sdk :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants