Ensure run with NODE_ENV set to test #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pmdartus
reviewed
Mar 5, 2019
| @@ -64,6 +64,10 @@ async function testRunner(argv) { | |||
|
|
|||
| shell.runCommand(command, commandArgs); | |||
| } else { | |||
| // Jest will not set the env if not run from the bin executable | |||
| if (process.env.NODE_ENV == null) { | |||
There was a problem hiding this comment.
If an environment variable is not set its value is always undefined and not null.
Suggested change
| if (process.env.NODE_ENV == null) { | |
| if (process.env.NODE_ENV === undefined) { |
There was a problem hiding this comment.
This is the exact code Jest uses. I want to keep parity between the two modes. It's very confusing to get a failure in a test and then try to debug and get different results.
|
@pmdartus Yeah, in non-debug mode we can run Jest via the same I remember @micmmakarov did it this way for testability, but I'm sure we can find a way to have parity between commands and also make it testable. Any concerns Mikhail? |
pmdartus
approved these changes
Mar 8, 2019
|
@trevor-bliss LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mimic the environment when the
jestexecutable is invoked directly, setprocess.env.NODE_ENVto 'test' if not already set.