Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): aria reflection new prop and typo #1012

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jan 25, 2019

Details

  • adding a missing aria prop
  • fixing the casing of an aria prop by spec

Does this PR introduce a breaking change?

  • Yes, if you were redefining property ariaHasPopUp in your component (which is pretty rare)
  • Yes, if you were adding a property called ariaColSpan decorated with @api in your component (which is also pretty rare)

@caridy caridy requested a review from ekashida January 25, 2019 18:43
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @lwc/template-compiler/src/parser/constants.ts had the correct set of aria attributes and these became out of sync...

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: f8423e8 | Target commit: 57e559e

lwc-engine-benchmark

table-append-1k metric base(f8423e8) target(57e559e) trend
benchmark-table/append/1k duration 151.25 (±4.65 ms) 151.75 (±4.65 ms) +0.5ms (0.3%) 👌
table-clear-1k metric base(f8423e8) target(57e559e) trend
benchmark-table/clear/1k duration 5.80 (±0.30 ms) 6.20 (±0.40 ms) +0.4ms (6.9%) 👎
table-create-10k metric base(f8423e8) target(57e559e) trend
benchmark-table/create/10k duration 864.55 (±6.65 ms) 882.05 (±7.05 ms) +17.5ms (2.0%) 👎
table-create-1k metric base(f8423e8) target(57e559e) trend
benchmark-table/create/1k duration 115.90 (±3.55 ms) 115.60 (±3.05 ms) -0.3ms (0.3%) 👌
table-update-10th-1k metric base(f8423e8) target(57e559e) trend
benchmark-table/update-10th/1k duration 75.05 (±4.40 ms) 84.60 (±2.30 ms) +9.5ms (12.7%) 👎
tablecmp-append-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-component/append/1k duration 251.55 (±8.80 ms) 250.15 (±4.85 ms) -1.4ms (0.6%) 👌
tablecmp-clear-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-component/clear/1k duration 11.50 (±1.60 ms) 12.40 (±1.65 ms) +0.9ms (7.8%) 👌
tablecmp-create-10k metric base(f8423e8) target(57e559e) trend
benchmark-table-component/create/10k duration 1760.50 (±10.10 ms) 1783.10 (±14.90 ms) +22.6ms (1.3%) 👎
tablecmp-create-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-component/create/1k duration 208.70 (±5.55 ms) 209.90 (±5.00 ms) +1.2ms (0.6%) 👌
tablecmp-update-10th-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-component/update-10th/1k duration 69.45 (±3.85 ms) 68.80 (±5.40 ms) -0.6ms (0.9%) 👌
wc-append-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-wc/append/1k duration 254.80 (±5.25 ms) 256.70 (±5.75 ms) +1.9ms (0.7%) 👌
wc-clear-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-wc/clear/1k duration 21.30 (±1.80 ms) 22.45 (±2.65 ms) +1.1ms (5.4%) 👎
wc-create-10k metric base(f8423e8) target(57e559e) trend
benchmark-table-wc/create/10k duration 1962.45 (±18.75 ms) 1992.35 (±10.85 ms) +29.9ms (1.5%) 👎
wc-create-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-wc/create/1k duration 220.55 (±3.85 ms) 221.70 (±4.75 ms) +1.1ms (0.5%) 👌
wc-update-10th-1k metric base(f8423e8) target(57e559e) trend
benchmark-table-wc/update-10th/1k duration 68.60 (±4.90 ms) 68.35 (±4.20 ms) -0.3ms (0.4%) 👌

caridy added a commit that referenced this pull request Jan 25, 2019
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 514c1f5 | Target commit: 6a31dd7

lwc-engine-benchmark

table-append-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table/append/1k duration 152.05 (±5.05 ms) 148.90 (±4.95 ms) -3.2ms (2.1%) 👍
table-clear-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table/clear/1k duration 5.90 (±0.30 ms) 5.80 (±0.40 ms) -0.1ms (1.7%) 👌
table-create-10k metric base(514c1f5) target(6a31dd7) trend
benchmark-table/create/10k duration 884.60 (±6.00 ms) 884.40 (±5.85 ms) -0.2ms (0.0%) 👌
table-create-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table/create/1k duration 117.20 (±2.35 ms) 116.90 (±2.10 ms) -0.3ms (0.3%) 👌
table-update-10th-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table/update-10th/1k duration 83.40 (±1.40 ms) 73.00 (±2.20 ms) -10.4ms (12.5%) 👍
tablecmp-append-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-component/append/1k duration 239.85 (±13.85 ms) 239.70 (±15.40 ms) -0.2ms (0.1%) 👌
tablecmp-clear-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-component/clear/1k duration 12.15 (±1.35 ms) 11.60 (±1.85 ms) -0.5ms (4.5%) 👌
tablecmp-create-10k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-component/create/10k duration 1759.45 (±14.95 ms) 1719.35 (±14.10 ms) -40.1ms (2.3%) 👍
tablecmp-create-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-component/create/1k duration 207.15 (±4.85 ms) 208.75 (±5.05 ms) +1.6ms (0.8%) 👌
tablecmp-update-10th-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-component/update-10th/1k duration 67.10 (±4.35 ms) 71.25 (±6.85 ms) +4.2ms (6.2%) 👌
wc-append-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-wc/append/1k duration 255.00 (±4.45 ms) 255.35 (±5.40 ms) +0.3ms (0.1%) 👌
wc-clear-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-wc/clear/1k duration 21.90 (±2.60 ms) 21.65 (±2.10 ms) -0.3ms (1.1%) 👌
wc-create-10k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-wc/create/10k duration 1969.00 (±19.40 ms) 1992.35 (±12.95 ms) +23.3ms (1.2%) 👎
wc-create-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-wc/create/1k duration 221.35 (±5.45 ms) 219.60 (±3.90 ms) -1.8ms (0.8%) 👌
wc-update-10th-1k metric base(514c1f5) target(6a31dd7) trend
benchmark-table-wc/update-10th/1k duration 66.70 (±4.45 ms) 68.65 (±4.45 ms) +2.0ms (2.9%) 👌

@caridy caridy merged commit 87d211c into master Jan 25, 2019
@caridy caridy deleted the caridy/aria-reflection-new-prop branch January 25, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants