fix(engine): prevent focus events when engine manages focus #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ekashida
force-pushed
the
ekashida/fixes-issue-1031
branch
from
bded9ce
to
d0f659b
Compare
This comment has been minimized.
This comment has been minimized.
ekashida
commented
Mar 19, 2019
| @@ -302,20 +321,14 @@ function keyboardFocusInHandler(event: FocusEvent) { | |||
| const post = relatedTargetPosition(host as HTMLElement, relatedTarget); | |||
| switch (post) { | |||
| case 1: // focus is probably coming from above | |||
| if ( | |||
| isFirstFocusableChildReceivingFocus && | |||
| relatedTarget === getPreviousTabbableElement(segments) | |||
There was a problem hiding this comment.
Looks like this change is the cause of the IE11 test failure.
There was a problem hiding this comment.
getPreviousTabbableElement is unreliable here since focusout is dispatched on the previous tabbable element before this focusin handler executes and the state of the DOM may change (e.g., the previously tabbable element is no longer tabbable). It seems that this check here is mainly to handle the case where the application focus enters the document? I'm not sure we can support both scenarios and I'm also not sure which scenario should take priority.
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
approved these changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes issue #1031. Bubbling focus events (i.e.
focusinandfocusout) resulting from our syntheticdelegatesFocusfocus management were causing component event handlers to execute and getting us into an unexpected state. Since engine focus management should be transparent to components we should just mute them.Does this PR introduce a breaking change?