fix: unify the descriptor creation process for restrictions #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pmdartus
reviewed
Mar 28, 2019
| @@ -37,7 +38,16 @@ import { | |||
| removeAttribute, | |||
| removeAttributeNS, | |||
| } from '../env/element'; | |||
| import { create } from './../shared/language'; | |||
|
|
|||
| function generateDescriptor(options: undefined | object): object { | |||
There was a problem hiding this comment.
Let's make this method signature a little more contained:
Suggested change
| function generateDescriptor(options: undefined | object): object { | |
| function generateDescriptor(options: PropertyDescriptor): object { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
caridy
reviewed
Mar 28, 2019
| @@ -393,37 +383,31 @@ function getCustomElementRestrictionsDescriptors( | |||
| const originalOuterHTMLDescriptor = getPropertyDescriptor(elm, 'outerHTML')!; | |||
| const originalTextContentDescriptor = getPropertyDescriptor(elm, 'textContent')!; | |||
| return assign(descriptors, { | |||
| innerHTML: { | |||
| innerHTML: generateDescriptor({ | |||
There was a problem hiding this comment.
this one is not correct because it should be enumerable I think...
I think you need two methods, not just one... one for methods (which they are always nonenumerable, non writable), and one for regular accessors which are normally enumerables, and non-writables.
There was a problem hiding this comment.
@caridy like we spoke, I updated the descriptors to match the native config. Here's the native descriptor shape for reference
Node.prototype.appendChild {value: ƒ, writable: true, enumerable: true, configurable: true}
Node.prototype.insertBefore {value: ƒ, writable: true, enumerable: true, configurable: true}
Node.prototype.removeChild {value: ƒ, writable: true, enumerable: true, configurable: true}
Node.prototype.replaceChild {value: ƒ, writable: true, enumerable: true, configurable: true}
Node.prototype.nodeValue {get: ƒ, set: ƒ, enumerable: true, configurable: true}
Node.prototype.textContent {get: ƒ, set: ƒ, enumerable: true, configurable: true}
Element.prototype.innerHTML {get: ƒ, set: ƒ, enumerable: true, configurable: true}
Element.prototype.outerHTML {get: ƒ, set: ƒ, enumerable: true, configurable: true}
Element.prototype.getAttribute {value: ƒ, writable: true, enumerable: true, configurable: true}
Element.prototype.setAttribute {value: ƒ, writable: true, enumerable: true, configurable: true}
Element.prototype.setAttributeNS {value: ƒ, writable: true, enumerable: true, configurable: true}
Element.prototype.removeAttribute {value: ƒ, writable: true, enumerable: true, configurable: true}
Element.prototype.removeAttributeNS {value: ƒ, writable: true, enumerable: true, configurable: true}
Element.prototype.tagName {get: ƒ, set: ƒ, enumerable: true, configurable: true}
ShadowRoot.prototype.innerHTML {get: ƒ, set: ƒ, enumerable: true, configurable: true}
EventTarget.prototype.addEventListener {value: ƒ, writable: true, enumerable: true, configurable: true}
DocumentFragment.prototype.querySelector {value: ƒ, writable: true, enumerable: true, configurable: true}
DocumentFragment.prototype.querySelectorAll {value: ƒ, writable: true, enumerable: true, configurable: true}
Document.prototype.getSelection {value: ƒ, writable: true, enumerable: true, configurable: true}
Document.prototype.elementsFromPoint {value: ƒ, writable: true, enumerable: true, configurable: true}```
This comment has been minimized.
This comment has been minimized.
pmdartus
approved these changes
Mar 29, 2019
| @@ -37,7 +38,27 @@ import { | |||
| removeAttribute, | |||
| removeAttributeNS, | |||
| } from '../env/element'; | |||
| import { create } from './../shared/language'; | |||
|
|
|||
| function generateDataDescriptor(options: PropertyDescriptor): object { | |||
There was a problem hiding this comment.
Another nitpick you can also constraint the output of the function.
Suggested change
| function generateDataDescriptor(options: PropertyDescriptor): object { | |
| function generateDataDescriptor(options: PropertyDescriptor): PropertyDescriptor { |
This comment has been minimized.
This comment has been minimized.
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
approved these changes
Mar 29, 2019
|
There are many failures, just make sure that you know what's going on there before merging this. |
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #1124
Does this PR introduce a breaking change?