Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template-compiler): remove lwc-depracated:is #1237

Merged
merged 1 commit into from
May 17, 2019

Conversation

pmdartus
Copy link
Member

Details

Fix #1086

Does this PR introduce a breaking change?

  • Yes
  • No

@pmdartus pmdartus requested a review from apapko May 17, 2019 08:41
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 7bc96eb | Target commit: 80e283b

lwc-engine-benchmark

table-append-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table/append/1k duration 150.80 (±5.60 ms) 146.75 (±5.15 ms) -4.1ms (2.7%) 👍
table-clear-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table/clear/1k duration 11.85 (±0.65 ms) 11.20 (±0.75 ms) -0.7ms (5.5%) 👍
table-create-10k metric base(7bc96eb) target(80e283b) trend
benchmark-table/create/10k duration 886.40 (±7.20 ms) 876.10 (±6.35 ms) -10.3ms (1.2%) 👍
table-create-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table/create/1k duration 119.25 (±2.85 ms) 117.05 (±2.90 ms) -2.2ms (1.8%) 👍
table-update-10th-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table/update-10th/1k duration 69.60 (±2.80 ms) 68.10 (±2.45 ms) -1.5ms (2.2%) 👍
tablecmp-append-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-component/append/1k duration 223.05 (±8.65 ms) 221.65 (±11.05 ms) -1.4ms (0.6%) 👌
tablecmp-clear-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-component/clear/1k duration 7.20 (±1.20 ms) 6.75 (±1.15 ms) -0.5ms (6.3%) 👌
tablecmp-create-10k metric base(7bc96eb) target(80e283b) trend
benchmark-table-component/create/10k duration 1760.60 (±14.70 ms) 1714.95 (±9.90 ms) -45.7ms (2.6%) 👍
tablecmp-create-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-component/create/1k duration 210.25 (±5.15 ms) 207.60 (±4.45 ms) -2.7ms (1.3%) 👌
tablecmp-update-10th-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-component/update-10th/1k duration 65.85 (±3.15 ms) 63.05 (±4.60 ms) -2.8ms (4.3%) 👌
wc-append-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-wc/append/1k duration 228.05 (±18.80 ms) 227.40 (±19.35 ms) -0.7ms (0.3%) 👌
wc-clear-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-wc/clear/1k duration 12.05 (±1.65 ms) 11.10 (±1.80 ms) -1.0ms (7.9%) 👍
wc-create-10k metric base(7bc96eb) target(80e283b) trend
benchmark-table-wc/create/10k duration 1844.10 (±20.85 ms) 1844.80 (±18.95 ms) +0.7ms (0.0%) 👌
wc-create-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-wc/create/1k duration 211.35 (±4.60 ms) 212.60 (±3.75 ms) +1.2ms (0.6%) 👌
wc-update-10th-1k metric base(7bc96eb) target(80e283b) trend
benchmark-table-wc/update-10th/1k duration 68.20 (±5.55 ms) 66.20 (±4.60 ms) -2.0ms (2.9%) 👌

Copy link
Contributor

@caridy caridy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's roll! thanks @pmdartus

@pmdartus pmdartus merged commit 149d1f6 into master May 17, 2019
@pmdartus pmdartus deleted the pmdartus/is-deprecated-removal branch May 17, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lwc-deprecated:is from the codebase
3 participants