Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): avoid reusing vnode.elm unless it is style tag for native #1365

Merged
merged 7 commits into from
Jun 21, 2019
Merged

fix(engine): avoid reusing vnode.elm unless it is style tag for native #1365

merged 7 commits into from
Jun 21, 2019

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jun 19, 2019

Details

  • remove logic to attempt to reuse vnode.elm unless it is an HTMLStyleElement for native shadow

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

@caridy caridy requested review from jodarove, ekashida and a user June 19, 2019 22:51
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: ab20a06 | Target commit: 3ee98b8

lwc-engine-benchmark

table-append-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table/append/1k duration 151.35 (±4.15 ms) 150.90 (±6.90 ms) -0.5ms (0.3%) 👌
table-clear-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table/clear/1k duration 11.10 (±0.75 ms) 11.30 (±1.30 ms) +0.2ms (1.8%) 👌
table-create-10k metric base(ab20a06) target(3ee98b8) trend
benchmark-table/create/10k duration 920.55 (±7.10 ms) 921.10 (±7.50 ms) +0.6ms (0.1%) 👌
table-create-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table/create/1k duration 117.30 (±4.25 ms) 114.70 (±3.20 ms) -2.6ms (2.2%) 👍
table-update-10th-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table/update-10th/1k duration 73.90 (±2.75 ms) 72.35 (±2.95 ms) -1.6ms (2.1%) 👍
tablecmp-append-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-component/append/1k duration 228.60 (±19.15 ms) 237.50 (±19.65 ms) +8.9ms (3.9%) 👌
tablecmp-clear-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-component/clear/1k duration 7.30 (±1.50 ms) 7.00 (±1.45 ms) -0.3ms (4.1%) 👌
tablecmp-create-10k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-component/create/10k duration 1799.35 (±12.30 ms) 1811.30 (±13.00 ms) +12.0ms (0.7%) 👎
tablecmp-create-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-component/create/1k duration 200.10 (±4.60 ms) 197.00 (±5.40 ms) -3.1ms (1.5%) 👌
tablecmp-update-10th-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-component/update-10th/1k duration 70.40 (±5.05 ms) 71.00 (±5.20 ms) +0.6ms (0.9%) 👌
wc-append-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-wc/append/1k duration 278.70 (±8.80 ms) 272.95 (±9.35 ms) -5.7ms (2.1%) 👌
wc-clear-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-wc/clear/1k duration 13.05 (±1.60 ms) 14.05 (±1.60 ms) +1.0ms (7.7%) 👌
wc-create-10k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-wc/create/10k duration 2207.65 (±12.60 ms) 2209.95 (±17.45 ms) +2.3ms (0.1%) 👌
wc-create-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-wc/create/1k duration 260.80 (±7.50 ms) 258.50 (±8.75 ms) -2.3ms (0.9%) 👌
wc-update-10th-1k metric base(ab20a06) target(3ee98b8) trend
benchmark-table-wc/update-10th/1k duration 72.30 (±4.75 ms) 70.35 (±5.60 ms) -2.0ms (2.7%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: ab20a06 | Target commit: a7b2637

lwc-engine-benchmark

table-append-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table/append/1k duration 151.35 (±4.15 ms) 150.55 (±4.30 ms) -0.8ms (0.5%) 👌
table-clear-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table/clear/1k duration 11.10 (±0.75 ms) 11.50 (±1.05 ms) +0.4ms (3.6%) 👌
table-create-10k metric base(ab20a06) target(a7b2637) trend
benchmark-table/create/10k duration 920.55 (±7.10 ms) 916.80 (±7.10 ms) -3.8ms (0.4%) 👍
table-create-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table/create/1k duration 117.30 (±4.25 ms) 116.00 (±3.85 ms) -1.3ms (1.1%) 👌
table-update-10th-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table/update-10th/1k duration 73.90 (±2.75 ms) 78.65 (±4.40 ms) +4.8ms (6.4%) 👌
tablecmp-append-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-component/append/1k duration 228.60 (±19.15 ms) 226.95 (±16.80 ms) -1.7ms (0.7%) 👌
tablecmp-clear-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-component/clear/1k duration 7.30 (±1.50 ms) 7.45 (±1.25 ms) +0.1ms (2.1%) 👌
tablecmp-create-10k metric base(ab20a06) target(a7b2637) trend
benchmark-table-component/create/10k duration 1799.35 (±12.30 ms) 1786.20 (±13.20 ms) -13.1ms (0.7%) 👍
tablecmp-create-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-component/create/1k duration 200.10 (±4.60 ms) 198.25 (±6.60 ms) -1.8ms (0.9%) 👌
tablecmp-update-10th-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-component/update-10th/1k duration 70.40 (±5.05 ms) 69.05 (±5.45 ms) -1.4ms (1.9%) 👌
wc-append-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-wc/append/1k duration 278.70 (±8.80 ms) 274.75 (±8.75 ms) -3.9ms (1.4%) 👌
wc-clear-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-wc/clear/1k duration 13.05 (±1.60 ms) 12.60 (±1.75 ms) -0.5ms (3.4%) 👌
wc-create-10k metric base(ab20a06) target(a7b2637) trend
benchmark-table-wc/create/10k duration 2207.65 (±12.60 ms) 2193.20 (±14.70 ms) -14.4ms (0.7%) 👍
wc-create-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-wc/create/1k duration 260.80 (±7.50 ms) 259.30 (±5.50 ms) -1.5ms (0.6%) 👌
wc-update-10th-1k metric base(ab20a06) target(a7b2637) trend
benchmark-table-wc/update-10th/1k duration 72.30 (±4.75 ms) 74.10 (±6.90 ms) +1.8ms (2.5%) 👌

@diervo
Copy link
Contributor

diervo commented Jun 20, 2019

I don't follow this PR...

ekashida
ekashida requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs tests.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 98a4ada | Target commit: e0c04ef

lwc-engine-benchmark

table-append-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table/append/1k duration 149.80 (±4.55 ms) 150.40 (±3.30 ms) +0.6ms (0.4%) 👌
table-clear-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table/clear/1k duration 11.30 (±0.85 ms) 11.40 (±0.80 ms) +0.1ms (0.9%) 👌
table-create-10k metric base(98a4ada) target(e0c04ef) trend
benchmark-table/create/10k duration 924.50 (±6.95 ms) 945.20 (±9.00 ms) +20.7ms (2.2%) 👎
table-create-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table/create/1k duration 116.60 (±3.05 ms) 114.05 (±3.50 ms) -2.5ms (2.2%) 👍
table-update-10th-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table/update-10th/1k duration 79.30 (±5.40 ms) 73.20 (±2.50 ms) -6.1ms (7.7%) 👍
tablecmp-append-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-component/append/1k duration 218.10 (±13.70 ms) 235.40 (±19.60 ms) +17.3ms (7.9%) 👌
tablecmp-clear-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-component/clear/1k duration 7.80 (±1.35 ms) 7.80 (±1.10 ms) 0.0ms (0.0%) 👌
tablecmp-create-10k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-component/create/10k duration 1806.20 (±10.95 ms) 1816.75 (±11.10 ms) +10.6ms (0.6%) 👎
tablecmp-create-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-component/create/1k duration 197.70 (±4.00 ms) 197.15 (±5.80 ms) -0.5ms (0.3%) 👌
tablecmp-update-10th-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-component/update-10th/1k duration 69.30 (±5.05 ms) 70.95 (±5.50 ms) +1.7ms (2.4%) 👌
wc-append-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-wc/append/1k duration 275.45 (±11.05 ms) 280.85 (±8.00 ms) +5.4ms (2.0%) 👎
wc-clear-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-wc/clear/1k duration 12.95 (±1.95 ms) 12.85 (±1.85 ms) -0.1ms (0.8%) 👌
wc-create-10k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-wc/create/10k duration 2184.00 (±19.65 ms) 2211.30 (±14.35 ms) +27.3ms (1.3%) 👎
wc-create-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-wc/create/1k duration 264.75 (±5.25 ms) 261.10 (±6.45 ms) -3.6ms (1.4%) 👍
wc-update-10th-1k metric base(98a4ada) target(e0c04ef) trend
benchmark-table-wc/update-10th/1k duration 71.05 (±7.00 ms) 71.05 (±4.10 ms) -0.0ms (0.0%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 98a4ada | Target commit: beb0952

lwc-engine-benchmark

table-append-1k metric base(98a4ada) target(beb0952) trend
benchmark-table/append/1k duration 149.80 (±4.55 ms) 150.80 (±5.75 ms) +1.0ms (0.7%) 👌
table-clear-1k metric base(98a4ada) target(beb0952) trend
benchmark-table/clear/1k duration 11.30 (±0.85 ms) 11.05 (±1.00 ms) -0.3ms (2.2%) 👌
table-create-10k metric base(98a4ada) target(beb0952) trend
benchmark-table/create/10k duration 924.50 (±6.95 ms) 921.75 (±9.60 ms) -2.8ms (0.3%) 👌
table-create-1k metric base(98a4ada) target(beb0952) trend
benchmark-table/create/1k duration 116.60 (±3.05 ms) 114.85 (±3.35 ms) -1.8ms (1.5%) 👌
table-update-10th-1k metric base(98a4ada) target(beb0952) trend
benchmark-table/update-10th/1k duration 79.30 (±5.40 ms) 79.80 (±4.10 ms) +0.5ms (0.6%) 👌
tablecmp-append-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-component/append/1k duration 218.10 (±13.70 ms) 230.45 (±18.85 ms) +12.3ms (5.7%) 👌
tablecmp-clear-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-component/clear/1k duration 7.80 (±1.35 ms) 7.70 (±1.55 ms) -0.1ms (1.3%) 👌
tablecmp-create-10k metric base(98a4ada) target(beb0952) trend
benchmark-table-component/create/10k duration 1806.20 (±10.95 ms) 1790.00 (±10.60 ms) -16.2ms (0.9%) 👍
tablecmp-create-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-component/create/1k duration 197.70 (±4.00 ms) 197.00 (±6.10 ms) -0.7ms (0.4%) 👌
tablecmp-update-10th-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-component/update-10th/1k duration 69.30 (±5.05 ms) 71.05 (±4.25 ms) +1.8ms (2.5%) 👌
wc-append-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-wc/append/1k duration 275.45 (±11.05 ms) 274.25 (±12.75 ms) -1.2ms (0.4%) 👌
wc-clear-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-wc/clear/1k duration 12.95 (±1.95 ms) 12.70 (±2.05 ms) -0.3ms (1.9%) 👌
wc-create-10k metric base(98a4ada) target(beb0952) trend
benchmark-table-wc/create/10k duration 2184.00 (±19.65 ms) 2224.05 (±12.45 ms) +40.1ms (1.8%) 👎
wc-create-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-wc/create/1k duration 264.75 (±5.25 ms) 262.10 (±5.70 ms) -2.6ms (1.0%) 👍
wc-update-10th-1k metric base(98a4ada) target(beb0952) trend
benchmark-table-wc/update-10th/1k duration 71.05 (±7.00 ms) 70.40 (±4.25 ms) -0.7ms (0.9%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 98a4ada | Target commit: ff32bf9

lwc-engine-benchmark

table-append-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table/append/1k duration 149.80 (±4.55 ms) 154.45 (±4.55 ms) +4.6ms (3.1%) 👎
table-clear-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table/clear/1k duration 11.30 (±0.85 ms) 11.50 (±1.20 ms) +0.2ms (1.8%) 👌
table-create-10k metric base(98a4ada) target(ff32bf9) trend
benchmark-table/create/10k duration 924.50 (±6.95 ms) 929.90 (±4.45 ms) +5.4ms (0.6%) 👎
table-create-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table/create/1k duration 116.60 (±3.05 ms) 114.15 (±2.90 ms) -2.4ms (2.1%) 👍
table-update-10th-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table/update-10th/1k duration 79.30 (±5.40 ms) 72.65 (±2.80 ms) -6.6ms (8.4%) 👍
tablecmp-append-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-component/append/1k duration 218.10 (±13.70 ms) 231.90 (±18.20 ms) +13.8ms (6.3%) 👌
tablecmp-clear-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-component/clear/1k duration 7.80 (±1.35 ms) 7.40 (±1.50 ms) -0.4ms (5.1%) 👌
tablecmp-create-10k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-component/create/10k duration 1806.20 (±10.95 ms) 1776.40 (±13.55 ms) -29.8ms (1.6%) 👍
tablecmp-create-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-component/create/1k duration 197.70 (±4.00 ms) 198.50 (±5.55 ms) +0.8ms (0.4%) 👌
tablecmp-update-10th-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-component/update-10th/1k duration 69.30 (±5.05 ms) 73.25 (±5.35 ms) +4.0ms (5.7%) 👌
wc-append-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-wc/append/1k duration 275.45 (±11.05 ms) 273.15 (±11.35 ms) -2.3ms (0.8%) 👌
wc-clear-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-wc/clear/1k duration 12.95 (±1.95 ms) 12.60 (±1.55 ms) -0.3ms (2.7%) 👌
wc-create-10k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-wc/create/10k duration 2184.00 (±19.65 ms) 2189.60 (±13.80 ms) +5.6ms (0.3%) 👌
wc-create-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-wc/create/1k duration 264.75 (±5.25 ms) 259.80 (±5.75 ms) -4.9ms (1.9%) 👍
wc-update-10th-1k metric base(98a4ada) target(ff32bf9) trend
benchmark-table-wc/update-10th/1k duration 71.05 (±7.00 ms) 68.65 (±3.40 ms) -2.4ms (3.4%) 👌

ekashida
ekashida requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass!

packages/integration-karma/test/rendering/elements-are-not-recycled/x/child/child.html Outdated Show resolved Hide resolved
packages/integration-karma/test/rendering/elements-are-not-recycled/index.spec.js Outdated
.then(() => {
child.open = true;

return Promise.resolve();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to return anything here, do we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we did (at least in jest) but we don't ... removed them

packages/integration-karma/test/rendering/elements-are-not-recycled/index.spec.js Outdated Show resolved Hide resolved
packages/integration-karma/test/rendering/elements-are-not-recycled/index.spec.js Outdated Show resolved Hide resolved
packages/integration-karma/test/rendering/elements-are-not-recycled/index.spec.js Outdated Show resolved Hide resolved
packages/integration-karma/test/rendering/elements-are-not-recycled/index.spec.js Outdated
import { createElement } from 'lwc';
import Container from 'x/container';

it('should not have have an error re-rendering slotted content', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we expect to see the error if elements were recycled? We should use a expect().not.toThrow() there.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 98a4ada | Target commit: cad5411

lwc-engine-benchmark

table-append-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/append/1k duration 149.80 (±4.55 ms) 154.85 (±5.60 ms) +5.1ms (3.4%) 👎
table-clear-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/clear/1k duration 11.30 (±0.85 ms) 11.45 (±1.30 ms) +0.1ms (1.3%) 👌
table-create-10k metric base(98a4ada) target(cad5411) trend
benchmark-table/create/10k duration 924.50 (±6.95 ms) 927.50 (±6.60 ms) +3.0ms (0.3%) 👌
table-create-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/create/1k duration 116.60 (±3.05 ms) 113.95 (±2.55 ms) -2.6ms (2.3%) 👍
table-update-10th-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/update-10th/1k duration 79.30 (±5.40 ms) 81.45 (±3.55 ms) +2.2ms (2.7%) 👌
tablecmp-append-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/append/1k duration 218.10 (±13.70 ms) 239.40 (±17.65 ms) +21.3ms (9.8%) 👎
tablecmp-clear-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/clear/1k duration 7.80 (±1.35 ms) 8.35 (±1.75 ms) +0.6ms (7.1%) 👌
tablecmp-create-10k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/create/10k duration 1806.20 (±10.95 ms) 1777.05 (±14.25 ms) -29.1ms (1.6%) 👍
tablecmp-create-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/create/1k duration 197.70 (±4.00 ms) 197.90 (±6.65 ms) +0.2ms (0.1%) 👌
tablecmp-update-10th-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/update-10th/1k duration 69.30 (±5.05 ms) 71.45 (±6.40 ms) +2.2ms (3.1%) 👌
wc-append-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/append/1k duration 275.45 (±11.05 ms) 277.30 (±7.35 ms) +1.8ms (0.7%) 👌
wc-clear-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/clear/1k duration 12.95 (±1.95 ms) 13.00 (±2.10 ms) +0.1ms (0.4%) 👌
wc-create-10k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/create/10k duration 2184.00 (±19.65 ms) 2250.00 (±16.40 ms) +66.0ms (3.0%) 👎
wc-create-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/create/1k duration 264.75 (±5.25 ms) 257.40 (±6.25 ms) -7.4ms (2.8%) 👍
wc-update-10th-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/update-10th/1k duration 71.05 (±7.00 ms) 70.90 (±5.35 ms) -0.2ms (0.2%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 98a4ada | Target commit: cad5411

lwc-engine-benchmark

table-append-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/append/1k duration 149.80 (±4.55 ms) 149.45 (±4.35 ms) -0.4ms (0.2%) 👌
table-clear-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/clear/1k duration 11.30 (±0.85 ms) 11.30 (±1.10 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(98a4ada) target(cad5411) trend
benchmark-table/create/10k duration 924.50 (±6.95 ms) 927.85 (±7.45 ms) +3.3ms (0.4%) 👌
table-create-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/create/1k duration 116.60 (±3.05 ms) 113.10 (±2.75 ms) -3.5ms (3.0%) 👍
table-update-10th-1k metric base(98a4ada) target(cad5411) trend
benchmark-table/update-10th/1k duration 79.30 (±5.40 ms) 74.00 (±5.60 ms) -5.3ms (6.7%) 👍
tablecmp-append-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/append/1k duration 218.10 (±13.70 ms) 240.90 (±17.60 ms) +22.8ms (10.5%) 👌
tablecmp-clear-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/clear/1k duration 7.80 (±1.35 ms) 7.15 (±1.35 ms) -0.6ms (8.3%) 👌
tablecmp-create-10k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/create/10k duration 1806.20 (±10.95 ms) 1799.80 (±10.90 ms) -6.4ms (0.4%) 👌
tablecmp-create-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/create/1k duration 197.70 (±4.00 ms) 199.10 (±5.05 ms) +1.4ms (0.7%) 👌
tablecmp-update-10th-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-component/update-10th/1k duration 69.30 (±5.05 ms) 71.15 (±6.30 ms) +1.9ms (2.7%) 👌
wc-append-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/append/1k duration 275.45 (±11.05 ms) 276.50 (±8.90 ms) +1.1ms (0.4%) 👌
wc-clear-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/clear/1k duration 12.95 (±1.95 ms) 12.70 (±1.65 ms) -0.3ms (1.9%) 👌
wc-create-10k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/create/10k duration 2184.00 (±19.65 ms) 2179.65 (±14.35 ms) -4.3ms (0.2%) 👌
wc-create-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/create/1k duration 264.75 (±5.25 ms) 260.20 (±6.25 ms) -4.6ms (1.7%) 👍
wc-update-10th-1k metric base(98a4ada) target(cad5411) trend
benchmark-table-wc/update-10th/1k duration 71.05 (±7.00 ms) 71.00 (±5.40 ms) -0.1ms (0.1%) 👌

ekashida
ekashida requested changes Jun 21, 2019
View reviewed changes
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the tests fail when expected to, without the bug fix. Thanks!

@caridy caridy merged commit 33f7e0c into master Jun 21, 2019
@caridy caridy deleted the caridy/reuse-vnode-bug branch June 21, 2019 23:00
@caridy caridy mentioned this pull request Jul 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diervo diervo diervo approved these changes

@ekashida ekashida ekashida approved these changes

@jodarove jodarove Awaiting requested review from jodarove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caridy @diervo @ekashida @jodarove