Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style compiler fails on COMPAT for nested var combined expressions #1376

Closed
diervo opened this issue Jun 25, 2019 · 0 comments · Fixed by #1378
Closed

Style compiler fails on COMPAT for nested var combined expressions #1376

diervo opened this issue Jun 25, 2019 · 0 comments · Fixed by #1378

Comments

@diervo
Copy link
Contributor

diervo commented Jun 25, 2019

Description

Error generating CSS for compat for nested compounded variables

Steps to Reproduce

.a {
    box-shadow: var(--x, 0 0 2px var(--y, #fff));
}

Should produce:

function stylesheet(hostSelector, shadowSelector, nativeShadow) {
  return ".a" + shadowSelector + " {box-shadow: " + varResolver("--lwc-c-active-button-box-shadow","0 0 2px " + varResolver("--lwc-brand-accessible","#0070d2")) + ";}\n";
}

Instead, its missing the concatenation operator when Text and Expression are combined within a variable expression.

This was referenced Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant