Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address security vulnerability CVE-2019-10744 #1407

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

ekashida
Copy link
Member

Upgrades lodash.template to version 4.5.0 or later via the following operations:

  • upgrade lerna 3.14.1 => 3.15.0
  • reinstall @commitlint/config-conventional
  • reinstall @commitlint/cli
  • reinstall conventional-changelog-cli

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

Upgrades lodash.template to version 4.5.0 or later via the following operations:
- upgrade lerna 3.14.1 => 3.15.0
- reinstall @commitlint/config-conventional
- reinstall @commitlint/cli
- reinstall conventional-changelog-cli
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: b09a145 | Target commit: 734f4b4

lwc-engine-benchmark

table-append-1k metric base(b09a145) target(734f4b4) trend
benchmark-table/append/1k duration 143.50 (±3.95 ms) 144.10 (±4.40 ms) +0.6ms (0.4%) 👌
table-clear-1k metric base(b09a145) target(734f4b4) trend
benchmark-table/clear/1k duration 10.55 (±0.85 ms) 9.95 (±0.90 ms) -0.6ms (5.7%) 👍
table-create-10k metric base(b09a145) target(734f4b4) trend
benchmark-table/create/10k duration 851.55 (±5.90 ms) 853.25 (±5.25 ms) +1.7ms (0.2%) 👌
table-create-1k metric base(b09a145) target(734f4b4) trend
benchmark-table/create/1k duration 108.70 (±2.45 ms) 108.45 (±2.45 ms) -0.3ms (0.2%) 👌
table-update-10th-1k metric base(b09a145) target(734f4b4) trend
benchmark-table/update-10th/1k duration 73.20 (±5.10 ms) 77.25 (±3.80 ms) +4.0ms (5.5%) 👌
tablecmp-append-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-component/append/1k duration 227.65 (±9.15 ms) 223.00 (±12.70 ms) -4.7ms (2.0%) 👍
tablecmp-clear-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-component/clear/1k duration 6.30 (±1.10 ms) 6.20 (±1.10 ms) -0.1ms (1.6%) 👌
tablecmp-create-10k metric base(b09a145) target(734f4b4) trend
benchmark-table-component/create/10k duration 1611.85 (±15.25 ms) 1601.45 (±21.15 ms) -10.4ms (0.6%) 👌
tablecmp-create-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-component/create/1k duration 186.00 (±4.50 ms) 185.65 (±4.40 ms) -0.3ms (0.2%) 👌
tablecmp-update-10th-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-component/update-10th/1k duration 68.75 (±6.65 ms) 69.85 (±5.60 ms) +1.1ms (1.6%) 👌
wc-append-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-wc/append/1k duration 233.10 (±12.30 ms) 229.95 (±11.90 ms) -3.2ms (1.4%) 👌
wc-clear-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-wc/clear/1k duration 11.00 (±1.85 ms) 11.05 (±1.15 ms) +0.1ms (0.5%) 👌
wc-create-10k metric base(b09a145) target(734f4b4) trend
benchmark-table-wc/create/10k duration 1835.00 (±12.45 ms) 1823.35 (±14.30 ms) -11.7ms (0.6%) 👍
wc-create-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-wc/create/1k duration 220.65 (±5.85 ms) 225.10 (±5.50 ms) +4.4ms (2.0%) 👎
wc-update-10th-1k metric base(b09a145) target(734f4b4) trend
benchmark-table-wc/update-10th/1k duration 65.80 (±4.55 ms) 66.25 (±3.90 ms) +0.5ms (0.7%) 👌

@caridy caridy merged commit 1fe64d8 into master Jul 12, 2019
@caridy caridy deleted the ekashida/CVE-2019-10744 branch July 12, 2019 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants