Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add N paths to generate packages #1411

Merged
merged 2 commits into from
Jul 15, 2019
Merged

feat: add N paths to generate packages #1411

merged 2 commits into from
Jul 15, 2019

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jul 15, 2019

Details

Allow multiple paths for canary generation

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a5be156 | Target commit: a500bc3

lwc-engine-benchmark

table-append-1k metric base(a5be156) target(a500bc3) trend
benchmark-table/append/1k duration 143.65 (±4.45 ms) 141.35 (±5.35 ms) -2.3ms (1.6%) 👍
table-clear-1k metric base(a5be156) target(a500bc3) trend
benchmark-table/clear/1k duration 10.65 (±1.00 ms) 9.85 (±0.90 ms) -0.8ms (7.5%) 👍
table-create-10k metric base(a5be156) target(a500bc3) trend
benchmark-table/create/10k duration 859.10 (±7.95 ms) 851.45 (±5.75 ms) -7.6ms (0.9%) 👍
table-create-1k metric base(a5be156) target(a500bc3) trend
benchmark-table/create/1k duration 110.50 (±3.25 ms) 106.65 (±2.40 ms) -3.8ms (3.5%) 👍
table-update-10th-1k metric base(a5be156) target(a500bc3) trend
benchmark-table/update-10th/1k duration 75.20 (±4.85 ms) 68.55 (±2.10 ms) -6.7ms (8.8%) 👍
tablecmp-append-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-component/append/1k duration 223.50 (±13.60 ms) 220.85 (±16.60 ms) -2.7ms (1.2%) 👌
tablecmp-clear-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-component/clear/1k duration 6.55 (±1.05 ms) 5.85 (±0.85 ms) -0.7ms (10.7%) 👌
tablecmp-create-10k metric base(a5be156) target(a500bc3) trend
benchmark-table-component/create/10k duration 1629.35 (±13.90 ms) 1632.30 (±24.70 ms) +3.0ms (0.2%) 👌
tablecmp-create-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-component/create/1k duration 186.55 (±3.70 ms) 184.60 (±5.50 ms) -1.9ms (1.0%) 👌
tablecmp-update-10th-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-component/update-10th/1k duration 68.70 (±4.95 ms) 65.10 (±3.70 ms) -3.6ms (5.2%) 👍
wc-append-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-wc/append/1k duration 232.00 (±9.85 ms) 231.30 (±10.05 ms) -0.7ms (0.3%) 👌
wc-clear-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-wc/clear/1k duration 10.70 (±1.65 ms) 10.50 (±1.65 ms) -0.2ms (1.9%) 👌
wc-create-10k metric base(a5be156) target(a500bc3) trend
benchmark-table-wc/create/10k duration 1871.20 (±13.60 ms) 1822.15 (±11.60 ms) -49.0ms (2.6%) 👍
wc-create-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-wc/create/1k duration 226.30 (±4.60 ms) 223.50 (±4.85 ms) -2.8ms (1.2%) 👍
wc-update-10th-1k metric base(a5be156) target(a500bc3) trend
benchmark-table-wc/update-10th/1k duration 66.90 (±4.75 ms) 67.35 (±4.60 ms) +0.4ms (0.7%) 👌

@diervo diervo merged commit 41e53e1 into master Jul 15, 2019
@diervo diervo deleted the dval/pathCanary branch July 15, 2019 09:56
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a5be156 | Target commit: d7ed5b4

lwc-engine-benchmark

table-append-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table/append/1k duration 143.65 (±4.45 ms) 139.30 (±3.05 ms) -4.3ms (3.0%) 👍
table-clear-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table/clear/1k duration 10.65 (±1.00 ms) 11.20 (±1.15 ms) +0.6ms (5.2%) 👌
table-create-10k metric base(a5be156) target(d7ed5b4) trend
benchmark-table/create/10k duration 859.10 (±7.95 ms) 854.10 (±5.90 ms) -5.0ms (0.6%) 👍
table-create-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table/create/1k duration 110.50 (±3.25 ms) 108.00 (±2.90 ms) -2.5ms (2.3%) 👍
table-update-10th-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table/update-10th/1k duration 75.20 (±4.85 ms) 72.80 (±5.55 ms) -2.4ms (3.2%) 👍
tablecmp-append-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-component/append/1k duration 223.50 (±13.60 ms) 214.40 (±15.05 ms) -9.1ms (4.1%) 👍
tablecmp-clear-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-component/clear/1k duration 6.55 (±1.05 ms) 6.25 (±0.85 ms) -0.3ms (4.6%) 👌
tablecmp-create-10k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-component/create/10k duration 1629.35 (±13.90 ms) 1625.30 (±11.80 ms) -4.0ms (0.2%) 👌
tablecmp-create-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-component/create/1k duration 186.55 (±3.70 ms) 188.05 (±4.45 ms) +1.5ms (0.8%) 👌
tablecmp-update-10th-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-component/update-10th/1k duration 68.70 (±4.95 ms) 66.30 (±5.50 ms) -2.4ms (3.5%) 👌
wc-append-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-wc/append/1k duration 232.00 (±9.85 ms) 229.30 (±10.65 ms) -2.7ms (1.2%) 👌
wc-clear-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-wc/clear/1k duration 10.70 (±1.65 ms) 10.75 (±1.95 ms) +0.1ms (0.5%) 👌
wc-create-10k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-wc/create/10k duration 1871.20 (±13.60 ms) 1848.30 (±13.85 ms) -22.9ms (1.2%) 👍
wc-create-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-wc/create/1k duration 226.30 (±4.60 ms) 220.10 (±4.20 ms) -6.2ms (2.7%) 👍
wc-update-10th-1k metric base(a5be156) target(d7ed5b4) trend
benchmark-table-wc/update-10th/1k duration 66.90 (±4.75 ms) 65.85 (±4.35 ms) -1.1ms (1.6%) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants