fix(engine): reactive setters behind a flag #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Aug 12, 2019
| import { isUndefined, isFunction } from '../../shared/language'; | ||
| import { getDecoratorsRegisteredMeta } from './register'; | ||
| import { addCallbackToNextTick } from '../utils'; | ||
| import { ENABLE_REACTIVE_SETTER } from '@lwc/features'; |
There was a problem hiding this comment.
@ekashida in vscode, I see this import marked as invalid export for some reason.
caridy
commented
Aug 12, 2019
| @@ -2,8 +2,7 @@ import { createElement } from 'test-utils'; | |||
|
|
|||
| import Parent from 'x/parent'; | |||
|
|
|||
| // TODO: issue #858 to enable reactive setters | |||
| xdescribe('Reactivity for setters', () => { | |||
| describe('Reactivity for setters', () => { | |||
There was a problem hiding this comment.
@ekashida how can we enable the flag here in the integration test?
ekashida
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Revert of the revert from #1038
This commit fixes #858
This commit includes a new flag called
ENABLE_REACTIVE_SETTER, that when enabled, makes all public setters reactive.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements: