fix: remove dead code #1503
Merged
fix: remove dead code #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravijayaramappa
commented
Sep 10, 2019
| @@ -44,7 +44,6 @@ export function logError(message: string, elm?: Element) { | |||
| if (elm) { | |||
| msg = `${msg}\n${getFormattedComponentStack(elm)}`; | |||
| } | |||
|
|
|||
| if (process.env.NODE_ENV === 'test') { | |||
There was a problem hiding this comment.
How about this one Caridy?
caridy
reviewed
Sep 11, 2019
| @@ -175,20 +174,6 @@ defineProperties(HTMLSlotElement.prototype, { | |||
| }, | |||
| children: { | |||
There was a problem hiding this comment.
you can remove the entire descriptor since it does nothing now.
caridy
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Remove dead code in @lwc/synthetic-shadow.
LWC Jest tests run in native shadow mode. There are a couple of branching logic for sythetic-shadow that are no longer necessary.
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements: