fix: package internal dependencies #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekashida the package you created (@lwc/shared) can't be private because its used in the compiler and is some other instances where the package might need to be resolved (cjs versions) |
diervo
changed the title
diervo
changed the title
muenzpraeger
approved these changes
Sep 28, 2019
caridy
reviewed
Sep 29, 2019
| @@ -18,6 +18,7 @@ | |||
| "@babel/plugin-proposal-object-rest-spread": "7.0.0", | |||
| "@lwc/babel-plugin-component": "1.0.2", | |||
| "@lwc/errors": "1.0.2", | |||
| "@lwc/shared": "1.0.2", | |||
There was a problem hiding this comment.
@ekashida you fixed some of this few days ago... you explicitly made shared private, but this PR is making it public, which is not ideal since we don't want people to rely on that pkg directly, only us.
There was a problem hiding this comment.
Nothing works in several packages because this is used in the main code...
|
I've opened #1542 as an alternative solution to this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There were some missing dependencies reported by @muenzpraeger
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.