fix(synthetic-shadow): querySelectors not returning #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manually inserted nodes in same shadow tree
| unfilteredNodes, | ||
| elm => getNodeNearestOwnerKey(elm) === ownerKey | ||
| ); | ||
| } else if (shadowDomSemantic === ShadowDomSemantic.Enabled) { |
There was a problem hiding this comment.
May be in a separate PR, the enum values should be in uppercase
ravijayaramappa
approved these changes
Oct 11, 2019
ekashida
approved these changes
Oct 11, 2019
| @@ -303,8 +316,7 @@ function querySelectorPatched(this: Element /*, selector: string*/): Element | n | |||
| ); | |||
| return isUndefined(elm) ? null : elm; | |||
| } else { | |||
| const elm = nodeList[0]; | |||
| return isUndefined(elm) ? null : elm; | |||
| return nodeList.length === 0 ? null : nodeList[0]; | |||
There was a problem hiding this comment.
Am I missing something or does this mean the same thing as before?
There was a problem hiding this comment.
the same thing, @ravijayaramappa says this way reveals more intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manually inserted nodes in same shadow tree
Details
This PR makes
querySelector,querySelectorAll,getElementsBy*to include manually inserted elements in the same shadow of the query context.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.