Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wire-service): compat integration tests #178

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

yungcheng
Copy link
Contributor

Details

update wire app template to be compatible with IE11, also fix a for...of issue in property-trap

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: b1b89e0 | Target commit: db24379

benchmark base(b1b89e0) target(db24379) trend
table-append-1k.benchmark:benchmark-table/append/1k 265.51 (± 10.35 ms) 259.08 (± 4.81 ms) 👍
table-clear-1k.benchmark:benchmark-table/clear/1k 14.86 (± 0.52 ms) 14.06 (± 0.45 ms) 👍
table-create-10k.benchmark:benchmark-table/create/10k 1489.89 (± 20.43 ms) 1471.23 (± 21.24 ms) 👌
table-create-1k.benchmark:benchmark-table/create/1k 159.75 (± 3.02 ms) 152.00 (± 2.01 ms) 👍
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 131.28 (± 3.07 ms) 127.48 (± 1.86 ms) 👍
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 330.55 (± 7.01 ms) 340.70 (± 7.03 ms) 👎
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 36.16 (± 1.32 ms) 40.11 (± 5.56 ms) 👎
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2676.15 (± 65.96 ms) 2618.01 (± 30.22 ms) 👍
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 279.07 (± 11.10 ms) 275.13 (± 6.04 ms) 👌
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 124.36 (± 2.08 ms) 121.81 (± 2.14 ms) 👍

@yungcheng yungcheng merged commit 71050f8 into master Mar 27, 2018
@yungcheng yungcheng deleted the fix-wire-integration-test branch March 27, 2018 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants