Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert preventDefault polyfill #207

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented Apr 6, 2018

Details

Revert CustomEvent.prototype.preventDefault polyfill change by upgrading the proxy-compat version to 0.17.39

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: f78a335 | Target commit: 5bf12fb

benchmark base(f78a335) target(5bf12fb) trend
table-append-1k.benchmark:benchmark-table/append/1k 247.38 (± 3.27 ms) 253.91 (± 5.41 ms) 👎
table-clear-1k.benchmark:benchmark-table/clear/1k 11.59 (± 0.35 ms) 13.89 (± 0.48 ms) 👎
table-create-10k.benchmark:benchmark-table/create/10k 1414.65 (± 13.26 ms) 1477.69 (± 21.97 ms) 👎
table-create-1k.benchmark:benchmark-table/create/1k 149.97 (± 2.35 ms) 155.74 (± 3.27 ms) 👎
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 124.04 (± 2.15 ms) 129.66 (± 2.11 ms) 👎
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 352.23 (± 6.14 ms) 330.77 (± 4.49 ms) 👍
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 34.87 (± 1.59 ms) 32.26 (± 1.23 ms) 👍
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2495.40 (± 22.68 ms) 2588.80 (± 40.38 ms) 👎
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 266.14 (± 1.69 ms) 271.99 (± 5.17 ms) 👎
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 112.53 (± 3.16 ms) 121.19 (± 3.20 ms) 👎

@pmdartus pmdartus merged commit 274b81c into master Apr 6, 2018
@pmdartus pmdartus deleted the pmdartus/revert-event-prevent-default branch April 6, 2018 04:12
pmdartus added a commit that referenced this pull request Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants