feat(lwc-compiler): add baseDir support #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by playground to compile sub components. Need baseDir to indicate position of root component within files object.
apapko
requested changes
Jun 5, 2018
| @@ -1,5 +1,9 @@ | |||
| import { isBoolean, isString, isUndefined } from "../utils"; | |||
|
|
|||
| const DEFAULT_OPTIONS = { | |||
| baseDir: "", | |||
There was a problem hiding this comment.
it would be great to have a small comment explaining the need for the baseDir
| return; | ||
| } | ||
|
|
||
| const relPath = importee ? path.dirname(importee) : ""; | ||
| let absPath = path.join(relPath, id); | ||
| const relPath = importer ? path.dirname(importer) : options.baseDir || ""; |
There was a problem hiding this comment.
do we need a more specific error message when importer is undefined and baseDir is not specified or should the line 65 take care of it?
Benchmark resultsBase commit: lwc-engine-benchmark
|
apapko
requested changes
Jun 6, 2018
| ...COMPILER_CONFIG_BASEDIR | ||
| }; | ||
| delete config.baseDir; | ||
| try { |
There was a problem hiding this comment.
it is better to use expect().rejects to ensure rejection is triggered
await expect(compile(config)).rejects.toMatchObject({
message: Could not resolve 'foo' (as foo.js) from compiler entry point
});
});| if (importer) { | ||
| throw new Error(`Could not resolve '${importee}' (as ${absPath}) from '${importer}'`); | ||
| } | ||
| throw new Error(`Could not resolve '${importee}' (as ${absPath}) from compiler entry point`); |
There was a problem hiding this comment.
thanks for the explicit error!
Benchmark resultsBase commit: |
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
apapko
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by playground to compile sub components. Need baseDir to
indicate position of root component within files object.
Details
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements: