fix(compiler): displaying correct ambigious attribute name #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapko
approved these changes
Jun 5, 2018
| @@ -53,9 +53,9 @@ function validatePropertyName(property) { | |||
| `Invalid property name "${propertyName}". "${propertyName}" is a reserved attribute.` | |||
| ); | |||
| } else if (AMBIGIOUS_PROP_SET.has(propertyName)) { | |||
| const { propName = propertyName } = GLOBAL_ATTRIBUTE_MAP.get(propertyName) || {}; | |||
| const camelCased = AMBIGIOUS_PROP_SET.get(propertyName); | |||
| throw property.buildCodeFrameError( | ||
| `Ambigious attribute name ${propertyName}. ${propertyName} will never be called from template because its corresponding property is camel cased. Consider renaming to "${propName}".` | ||
| `Ambigious attribute name ${propertyName}. ${propertyName} will never be called from template because its corresponding property is camel cased. Consider renaming to "${camelCased}".` |
| } | ||
| `, { | ||
| error: { | ||
| message: 'test.js: Ambigious attribute name maxlength. maxlength will never be called from template because its corresponding property is camel cased. Consider renaming to "maxLength".', |
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
maxlength->maxLengthin warningDoes this PR introduce a breaking change?