Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Adding warning on native shadow childNodes #382

Merged
merged 3 commits into from
Jun 6, 2018

Conversation

davidturissini
Copy link
Contributor

Details

  • Includes method in shadow warnings
  • Adds warning in native mode

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a4c21a0 | Target commit: feddc25

lwc-engine-benchmark

table-append-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table/append/1k duration 149.10 (± 3.90 ms) 146.70 (± 5.40 ms) 1.61% 👍
table-clear-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table/clear/1k duration 11.70 (± 0.40 ms) 11.30 (± 0.50 ms) 3.42% 👍
table-create-10k metric base(a4c21a0) target(feddc25) trend
benchmark-table/create/10k duration 856.50 (± 3.60 ms) 844.40 (± 5.60 ms) 1.41% 👍
table-create-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table/create/1k duration 103.90 (± 1.20 ms) 101.70 (± 1.60 ms) 2.12% 👍
table-update-10th-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table/update-10th/1k duration 92.70 (± 4.90 ms) 86.30 (± 4.80 ms) 6.90% 👍
tablecmp-append-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table-component/append/1k duration 258.60 (± 4.00 ms) 254.15 (± 4.05 ms) 1.72% 👍
tablecmp-clear-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table/clear/1k duration 35.90 (± 1.70 ms) 35.60 (± 1.40 ms) 0.84% 👌
tablecmp-create-10k metric base(a4c21a0) target(feddc25) trend
benchmark-table-component/create/10k duration 1688.30 (± 8.20 ms) 1681.90 (± 8.50 ms) 0.38% 👌
tablecmp-create-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table-component/create/1k duration 198.10 (± 3.50 ms) 196.40 (± 4.40 ms) 0.86% 👌
tablecmp-update-10th-1k metric base(a4c21a0) target(feddc25) trend
benchmark-table-component/update-10th/1k duration 76.70 (± 4.75 ms) 75.30 (± 5.70 ms) 1.83% 👌

@davidturissini davidturissini merged commit 156b03d into master Jun 6, 2018
@davidturissini davidturissini deleted the dturissini/patched-elements-warnings branch June 6, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants