Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Lock in uglify-es version #42

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

trevor-bliss
Copy link
Contributor

PR Checklist

What kind of change does this PR introduce? (add 'x' - [x])

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

The PR fulfills these requirements:

  • Tests for the changes have been added (for bug fixes / features)

  • Both unit and integration tests pass

  • Docs have been added / updated (for bug fixes / features)

  • The PR title follows conventional commit format:
    commit-type(optional scope): commit description.

    Supported commit types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test.
    Supported scope: The scope should be the name of the npm package affected (engine, compiler, wire-service, etc.)
    
  • More details on LWC semantic commit can be found here.

Other information:

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: a29cbcd | Target commit: 3ab8916

benchmark base(a29cbcd) target(3ab8916) trend
append-1k.benchmark:benchmark-table/add/1k 360.96 (± 19.81 ms) 462.20 (± 19.81 ms) 👎
clear-1k.benchmark:benchmark-table/clear/1k 56.16 (± 4.53 ms) 74.82 (± 4.53 ms) 👎
create-1k.benchmark:benchmark-table/create/1k 218.16 (± 18.55 ms) 283.70 (± 18.55 ms) 👎
update-10th-1k.benchmark:benchmark-table/update-10th/1k 203.35 (± 17.16 ms) 278.07 (± 17.16 ms) 👎

@trevor-bliss trevor-bliss merged commit b76e980 into master Jan 25, 2018
@trevor-bliss trevor-bliss deleted the master-hotfix-prod-uglify-version branch January 25, 2018 01:35
pmdartus pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant