feat: CSS variable injection #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
commented
Jun 18, 2018
| import { transform } from '../../transformers/transformer'; | ||
| import { pretify } from '../../__tests__/utils'; | ||
|
|
||
| describe('transform', () => { |
There was a problem hiding this comment.
Reorganize the tests per file type.
| "allowJs": false, | ||
| "checkJs": false, |
There was a problem hiding this comment.
Make typescript stricter for the postcss-plugin-lwc project.
Benchmark resultsBase commit: |
apapko
reviewed
Jun 19, 2018
| expect(() => transform()).toThrow( | ||
| /Expect a string for source. Received undefined/ | ||
| /Expect a string for source. Received undefined/, |
| } | ||
| }); | ||
| it("should apply transformation for valid javascript file", async () => { | ||
| describe('javascript transform', () => { |
There was a problem hiding this comment.
for consistency with html and css test descriptions, perhaps we can capitalize JAVASCRIPT transform. Also wondering if we need the word transform since the root level describe is already named transform
| @@ -1,68 +1,100 @@ | |||
| import * as postcss from "postcss"; | |||
| import * as cssnano from "cssnano"; | |||
| import postcssPluginRaptor from "postcss-plugin-lwc"; | |||
| import postcssPluginLwc from "postcss-plugin-lwc"; | |||
There was a problem hiding this comment.
thanks for renaming! raptor no more
| "export default style;" | ||
| ].join("\n"); | ||
| /** | ||
| * Transform the var function to a call expression to the custom properties resolver with |
There was a problem hiding this comment.
description is a bit confusing. Are we doing transform var function to a call expression in a form of custom properties resolver...?
| token: TOKEN_PLACEHOLDER, | ||
| customProperties: { | ||
| allowDefinition: customProperties.allowDefinition, |
There was a problem hiding this comment.
is existence check needed prior accessing allowDefinition?
There was a problem hiding this comment.
No need since it gets normalized.
| @@ -51,42 +17,35 @@ function transform(decl: Declaration, transformer: VarTransformer, value: string | |||
| return value; | |||
| } | |||
|
|
|||
| const [, prefix] = varMatch; | |||
| // Prefix is either an empty string or a whitespace depending if the `var()` function is | |||
| @@ -17,6 +24,15 @@ export type OutputProxyCompatConfig = | |||
| | { module: string } | |||
| | { independent: string }; | |||
|
|
|||
| export interface CustomPropertiesConfig { | |||
| allowDefinition?: boolean; | |||
| resolveFromModule?: string; | |||
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add custom properties injection support as outlined in the RF0105 CSS custom properties injection.
Does this PR introduce a breaking change?