Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-utils): convert to cjs module #431

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

trevor-bliss
Copy link
Contributor

Details

Test util should be a CJS module so it can be directly imported in Jest unit tests.

Does this PR introduce a breaking change?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 282e3d2 | Target commit: 91884f7

@diervo diervo merged commit 3e65275 into master Jun 20, 2018
@diervo diervo deleted the tbliss/getShadowRoot-cjs branch June 20, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants