Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining vestiges of jest types #4422

Closed
nolanlawson opened this issue Jul 29, 2024 · 0 comments · Fixed by #4435
Closed

Remove remaining vestiges of jest types #4422

nolanlawson opened this issue Jul 29, 2024 · 0 comments · Fixed by #4435

Comments

@nolanlawson
Copy link
Collaborator

Follow-up to #4396

If you search the codebase for jest, you can still find some Jest-related TypeScript types, e.g.:

import MatcherUtils = jest.MatcherUtils;
import CustomMatcherResult = jest.CustomMatcherResult;

These should be migrated to use vitest types instead.

We do also use eslint-plugin-jest, but that's maybe less of a big deal since Jest semantics look very similar to Vitest's. Also apparently eslint-plugin-vitest is not officially-supported by the Vitest project and says "Most of the rules in this plugin are essentially ports of eslint-plugin-jest".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant