Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from yarn to pnpm #4426

Open
nolanlawson opened this issue Jul 31, 2024 · 4 comments
Open

Migrate from yarn to pnpm #4426

nolanlawson opened this issue Jul 31, 2024 · 4 comments
Labels
enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

We are still using yarn v1 in this repo – we should migrate to a more modern solution.

After internal discussion we decided on pnpm. Two challenges:

  1. Volta has experimental pnpm support – developers will have to enable an env variable.
  2. The tachometer build script will need to be agnostic to pnpm vs yarn since it might test against older commits that are still using yarn. We can use the presence or absence of yarn.lock to test for this
  3. GitHub Actions needs to use whatever version of pnpm we are using in our Volta config
@harshsbhat
Copy link

Would like to work on this. Is this issue ready to work on?

@nolanlawson
Copy link
Collaborator Author

@harshsbhat Sure, this is available. Thanks in advance!

@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Aug 5, 2024
@SourabhMulay
Copy link
Contributor

Hi @nolanlawson ,

I hope you're doing well!

I’ve attempted to migrate to pnpm, but after running pnpm install for some dependencies, I encountered the following error:

ERR_PNPM_FETCH_404  GET https://registry.yarnpkg.com/@lwc%2Flwc-modules-bar: Not Found - 404"
@lwc/lwc-modules-bar  is not in the npm registry, or you have no permission to fetch it.
No authorization header was set for the request.

It seems that @lwc/lwc-modules-bar is not available in the npm registry, or I may not have the necessary permissions to fetch it. Additionally, no authorization header was set for the request.
Could you please provide any insights or suggestions on how to resolve this issue?

Thank you for your help!

@wjhsf
Copy link
Contributor

wjhsf commented Sep 26, 2024

That's not a real module, it's just used in a test fixture. You'll need to configure pnpm to ignore package.json files found in any __tests__ directory.

"@lwc/lwc-modules-foo": "1.0.0",
"@lwc/lwc-modules-bar": "1.0.0"

Also, seems weird to be using pnpm, but using the yarn registry. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

4 participants